github
04/12/2024, 9:10 AM<https://github.com/solidusio/solidus/commit/f0b12fbe105cd63c1745710b2cdf535d28a2a902|f0b12fbe105cd63c1745710b2cdf535d28a2a902>
Show the page action for creating a new shipping method - Chris Todorov
<https://github.com/solidusio/solidus/commit/8a5b25739adcbb61ba1e5a3b26f94e0ed6c5671d|8a5b25739adcbb61ba1e5a3b26f94e0ed6c5671d>
Merge pull request #5719 from SuperGoodSoft/feature/solidus_admin/add-new-shipping-method-page-action - Thomas von Deyengithub
04/12/2024, 9:10 AMgithub
04/12/2024, 9:10 AM<https://github.com/solidusio/solidus/commit/aea7119bd619c12a468e3d83d01d3fd70ddbd8e4|aea7119bd619c12a468e3d83d01d3fd70ddbd8e4>
Rename translation file with correct name - andrea longhi
<https://github.com/solidusio/solidus/commit/4b346d0519eb71b052a706f185712b08f3df8639|4b346d0519eb71b052a706f185712b08f3df8639>
Add new refund reason modal form - andrea longhi
<https://github.com/solidusio/solidus/commit/ec4234d6a5037261070a9ecbe54f741a64c360c8|ec4234d6a5037261070a9ecbe54f741a64c360c8>
Create new refund reasons - andrea longhi
<https://github.com/solidusio/solidus/commit/9fb0abb01d0eeca43a21b9cf12255d3f5849e99f|9fb0abb01d0eeca43a21b9cf12255d3f5849e99f>
Merge pull request #5696 from nebulab/spaghetticode/admin-new-refund-reason - Thomas von Deyengithub
04/12/2024, 9:11 AMgithub
04/12/2024, 9:11 AM<https://github.com/solidusio/solidus/commit/a4b52a62d131b14a3571a9593bf5dc610e68df83|a4b52a62d131b14a3571a9593bf5dc610e68df83>
Add edit and update tax category routes - andrea longhi
<https://github.com/solidusio/solidus/commit/db655311cce0e787b9a3547ebeb61ccef2553213|db655311cce0e787b9a3547ebeb61ccef2553213>
Add edit tax category modal turbo frame - andrea longhi
<https://github.com/solidusio/solidus/commit/055e6f06a454afcc757676d5bde6306dcd736784|055e6f06a454afcc757676d5bde6306dcd736784>
Add tax_categories/edit component - andrea longhi
<https://github.com/solidusio/solidus/commit/f38fbd67fdef378667c5a5a8a8524fb45a974536|f38fbd67fdef378667c5a5a8a8524fb45a974536>
Add tax category edit and update actions - andrea longhi
<https://github.com/solidusio/solidus/commit/cb0ff1ee4ab02200de41b8d2fffd5b978a0cc401|cb0ff1ee4ab02200de41b8d2fffd5b978a0cc401>
Merge pull request #5697 from nebulab/spaghetticode/update-tax-category - Thomas von Deyengithub
04/12/2024, 9:11 AMgithub
04/12/2024, 9:14 AMgithub
04/12/2024, 10:19 AMgithub
04/12/2024, 1:31 PMgithub
04/17/2024, 11:39 AMsolidus_legacy_promotions
. This PR removes the dependency from ``solidus_admin`` to solidus_legacy_promotions
.
This was pretty hard to do, because there's not a lot of support for differentiating between the two types of admin from an RSpec perspective. What we ended up doing was define a global switch for the DummyApp. If anyone is aware of something like RSpec.current_test.metadata
, that would be even nicer, but I have not found it.
This is also probably the first gem that makes use of the new admin, so it's a good discussion point for how we provide testing facilities for gems consuming the new admin.
Note that currently, solidus_legacy_promotions
must still depend on both ``solidus_admin`` and solidus_backend
, because otherwise the specs don't run (they use constants defined in the gems) and - more importantly - the autoloader will fail to autoload controllers and components from `solidus_legacy_promotions`
.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
• [x] I have written a thorough PR description.
• [ ] I have kept my commits small and atomic.
The first commit is not green, nor will it be. But the changes from the second commit tell what's wrong, so I'm opting to leave these separate for now.
• [x] I have used clear, explanatory commit messages.
The following are not always needed:
• 📖 I have updated the README to account for my changes.
• 📑 I have documented new code with YARD.
• 🛣️ I have opened a PR to update the guides.
• ✅ I have added automated tests to cover my changes.
• 📸 I have attached screenshots to demo visual changes.
.github/CONTRIBUTING.md at main · solidusio/.github
Contribute to solidusio/.github development by creating an account on GitHub.
GitHub - solidusio/edgeguides: Developer documentation for the Solidus eCommerce framework.
Developer documentation for the Solidus eCommerce framework. - solidusio/edgeguidesgithub
04/17/2024, 12:07 PMgithub
04/17/2024, 12:07 PM<https://github.com/solidusio/solidus/commit/2d5296f177465d05affd2fec29376c6e9cdb20de|2d5296f177465d05affd2fec29376c6e9cdb20de>
fix(CI): Set ESLINT_USE_FLAT_CONFIG=false - Thomas von Deyen
<https://github.com/solidusio/solidus/commit/3f6c58c583a8f55eb2294a421bb8718e64013e01|3f6c58c583a8f55eb2294a421bb8718e64013e01>
Merge pull request #5721 from tvdeyen/fix-eslint - Thomas von Deyengithub
04/17/2024, 12:08 PMgithub
04/17/2024, 12:08 PMmain
to ``v4.3``:
• Merge pull request #5721 from tvdeyen/fix-eslint
<!--- Backport version: 9.3.0 -->
Questions ?
Please refer to the Backport tool documentation
GitHub - sorenlouv/backport: A simple CLI tool that automates the process of backporting commits on a GitHub repo
A simple CLI tool that automates the process of backporting commits on a GitHub repo - sorenlouv/backportgithub
04/17/2024, 12:10 PMgithub
04/17/2024, 12:10 PMgithub
04/17/2024, 12:10 PM<https://github.com/solidusio/solidus/commit/67f9219504cd276d07a7dd2bad1e19918766287c|67f9219504cd276d07a7dd2bad1e19918766287c>
fix(CI): Set ESLINT_USE_FLAT_CONFIG=false - Thomas von Deyen
<https://github.com/solidusio/solidus/commit/5dbd82cbc93f5b120aea28cd82a9fb4940633923|5dbd82cbc93f5b120aea28cd82a9fb4940633923>
Merge pull request #5725 from solidusio/backport/v4.3/pr-5721 - Thomas von Deyengithub
04/17/2024, 3:23 PMsolidus_legacy_promotions
[solidusio/solidus] Pull request submitted by mamhoff
Summary
Solidus main already depends on solidus_legacy_promotions
, but we forgot to require it in the original PR. This makes sure people still have the legacy promotion system when they upgrade to the next Solidus version.github
04/17/2024, 7:55 PMgithub
04/18/2024, 6:27 AMgithub
04/18/2024, 6:27 AM<https://github.com/solidusio/solidus/commit/9c109183662900194b5522b64a2cafa31859e65d|9c109183662900194b5522b64a2cafa31859e65d>
Solidus gem: Require solidus_legacy_promotions
- Martin Meyerhoff
<https://github.com/solidusio/solidus/commit/3d9fc74812f7a5d5924f8ac54ead4da8e08cdd2c|3d9fc74812f7a5d5924f8ac54ead4da8e08cdd2c>
Merge pull request #5726 from mamhoff/solidus-depend-on-legacy-promotions - Thomas von Deyengithub
04/18/2024, 12:04 PMSpree::Config.promotions
leads to the object
being instacached and very, very hard to change.
Also, we currently have to spots in the app where we can configure the
promotion api attributes, and this reduces it to just one by deprecating
the preference :promotion_attributes on Spree::ApiConfiguration
.
This includes some commit from #5727 to see the tests through.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
• [x] I have written a thorough PR description.
• [x] I have kept my commits small and atomic.
• [x] I have used clear, explanatory commit messages.
.github/CONTRIBUTING.md at main · solidusio/.github
Contribute to solidusio/.github development by creating an account on GitHub.github
04/18/2024, 12:06 PMgithub
04/18/2024, 12:06 PM<https://github.com/solidusio/solidus/commit/4319e17023da3adaf09a5a4d87ae154ae6e0dbb5|4319e17023da3adaf09a5a4d87ae154ae6e0dbb5>
Restrict sqlite3 gem to '~> 1.3', like ActiveRecord - Martin Meyerhoff
<https://github.com/solidusio/solidus/commit/e85fd4cd7300b1e8f4f5f142cc6f5d41003ca23e|e85fd4cd7300b1e8f4f5f142cc6f5d41003ca23e>
Restrict sqlite3 for the extension generator - Martin Meyerhoff
<https://github.com/solidusio/solidus/commit/7ba0f9869e1d1e9d9abfb3f09c80ebfa46388140|7ba0f9869e1d1e9d9abfb3f09c80ebfa46388140>
Merge pull request #5727 from mamhoff/restrict-sqlite-to-1.x - Alberto Venagithub
04/18/2024, 12:26 PMshipping_promotion_handler_class
attribute to null promo config
[solidusio/solidus] Pull request submitted by mamhoff
Summary
We have a shipping_promotion_handler_class in the legacy promotion system, and we have calling code from Solidus itself, so we need to add this configuration option to the null promotion configuration, too.github
04/18/2024, 1:34 PMgithub
04/18/2024, 1:34 PM<https://github.com/solidusio/solidus/commit/fd7b8e9b77e395d025499fb427326c4af7229c0e|fd7b8e9b77e395d025499fb427326c4af7229c0e>
Move promotion stuff from admin to legacy_promotions - Martin Meyerhoff
<https://github.com/solidusio/solidus/commit/748c6c210b2a6a7b4ed3410357e82c63ec3a5593|748c6c210b2a6a7b4ed3410357e82c63ec3a5593>
Allow turning solidus_admin on and off for certain specs - Martin Meyerhoff
<https://github.com/solidusio/solidus/commit/16110fb8214b1e9cea87af78e29310c1a008307d|16110fb8214b1e9cea87af78e29310c1a008307d>
Move promo controllers and routes to legacy_promotions - Martin Meyerhoff
<https://github.com/solidusio/solidus/commit/9db47df9fd72eb88f18860460890b8e0860d43e0|9db47df9fd72eb88f18860460890b8e0860d43e0>
Conditionally add Promotion views for new Admin - Martin Meyerhoff
<https://github.com/solidusio/solidus/commit/bce5114647af98d33c6d4812ebad2c68a83ac3ea|bce5114647af98d33c6d4812ebad2c68a83ac3ea>
Rename feature spec dir "admin" to "backend" - Martin Meyerhoff
<https://github.com/solidusio/solidus/commit/68b294f563051dde055148eccd1329489c8e358c|68b294f563051dde055148eccd1329489c8e358c>
Merge pull request #5724 from mamhoff/move-solidus-admin-promotion-to-legacy-promotions - Alberto Venagithub
04/18/2024, 2:39 PMsolidus_backend
gem and a production/API environment with the ``backend`` gem and routes excluded.
The way it works is the same way we loosened the dependency for `solidus_admin`: We don't depend on it, and rescue the ``LoadError`` when it's not there. That way, SolidusSupport's EngineExtensions
will automatically add `lib/controllers`
and ``lib/views``
from ```solidus_legacy_promotions```
to the load path. Voila!
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
• [x] I have written a thorough PR description.
• [x] I have kept my commits small and atomic.
• [x] I have used clear, explanatory commit messages.
.github/CONTRIBUTING.md at main · solidusio/.github
Contribute to solidusio/.github development by creating an account on GitHub.github
04/18/2024, 3:33 PMgithub
04/18/2024, 3:40 PM