Finally we switched to PR based workflow. life is ...
# seed
s
Finally we switched to PR based workflow. life is better , also after the deployment the outputs are mentioned in gitlab thats good. But I have two suggestion : 1. In the screenshot, see it only shows pr number, is it possible to show here who owns it, the name of the PR and may be the branch name. I am happy with the stage name, just this extra details if you guys display it will be much more easy to see which dev is doing what. 2. While vercel deploys our frontend site, it shows pipeline running in gitlab and i can restrict merging that time. Currently we are using seed to run our unittests thats working as expected, but there is a chance that we might merge the branch from gitlab mistakenly. it will make our workflow much more "idiot proof"
a
Why
dev
is in staging?
s
its the default seed naming, i did not change
a
Dev under staging? weird.
f
Hey @Sourav Sarkar, Re 1: for sure, something we are aware of 👍 Re 2: are you also using GitLab pipelines? Can you elaborate on ur workflow a bit?
s
Copy code
are you also using GitLab pipelines? Can you elaborate on ur workflow a bit?
Our workflow is similar to this https://medium.com/serverless-transformation/serverless-flow-a-ci-cd-branching-workflow-optimized-for-speed-and-quality-6b98c5a4e489 developers create feature branches from
master
. They raise MRs and seed creates temporary infra structure for the MR and runs unit tests. Gitlab has a feature --> MR must succeed for MR to merge --> we enable it, and when we push our frontend code for vercel (similar workflow), gitlab shows the vercel deployment as external pipeline (we do not keep the gitlab ci file), and does not allow the MR to merge till the deployment finishes. We run our unittests and linting checks in vercel, so devs cant merge if their code is not passing those standards as otherwise the vercel deployment fails. In case of the backend repo, if I enable the feature in gitlab, then gitlab does not detect the "external pipeline" running at seed and developers can my mistake merge their code to master Of course it will not destroy our production, as for production release we release from seed by manually promoting the staging build
f
Got it. Do you have a link to the “external pipeline” feature on GitLab? I think if we integrated w/ it, you can get the same effect for your frontend.