Sourav Sarkar
11/10/2021, 4:35 PMAdrián Mouly
11/10/2021, 5:10 PMdev
is in staging?Sourav Sarkar
11/11/2021, 2:26 AMAdrián Mouly
11/11/2021, 3:51 AMFrank
Sourav Sarkar
11/12/2021, 12:58 PMare you also using GitLab pipelines? Can you elaborate on ur workflow a bit?
Our workflow is similar to this https://medium.com/serverless-transformation/serverless-flow-a-ci-cd-branching-workflow-optimized-for-speed-and-quality-6b98c5a4e489
developers create feature branches from master
. They raise MRs and seed creates temporary infra structure for the MR and runs unit tests.
Gitlab has a feature --> MR must succeed for MR to merge --> we enable it, and when we push our frontend code for vercel (similar workflow), gitlab shows the vercel deployment as external pipeline (we do not keep the gitlab ci file), and does not allow the MR to merge till the deployment finishes. We run our unittests and linting checks in vercel, so devs cant merge if their code is not passing those standards as otherwise the vercel deployment fails.
In case of the backend repo, if I enable the feature in gitlab, then gitlab does not detect the "external pipeline" running at seed and developers can my mistake merge their code to master
Of course it will not destroy our production, as for production release we release from seed by manually promoting the staging buildFrank