WIth pr based deploys in SEED, is there a way of w...
# seedo
Omi Chowdhury
04/11/2022, 7:33 PMWIth pr based deploys in SEED, is there a way of waiting for our unit & integration tests that run via github actions to finish before deploying?
f
Frank
04/11/2022, 7:42 PM
Hey @Omi Chowdhury, there’s the Connect external CI option. It awaits for all GH checks to succeed to trigger the deploy.
Frank
04/11/2022, 7:43 PM
That said, we more often recommend calling the SEED CLI in ur GH action to trigger a build, instead of using the PR workflow.
Frank
04/11/2022, 7:43 PM
It’s more stable and flexible this way.
o
Omi Chowdhury
04/11/2022, 7:44 PMOk, we have that options set, but still seems to trigger simultaneously
f
Frank
04/11/2022, 9:01 PM
I see. Can you send me a link to the build?
Frank
04/11/2022, 9:06 PM
A bit of context, there actually isn't a fully reliable way to check for all GH checks have passed. Connect external CI option was originally introduced prior to GH actions time and was intended to work with Circle CI and Travis.
Frank
04/11/2022, 9:06 PM
We are actually planning to phase out the feature in favor for SEED CLI.
o
Omi Chowdhury
04/12/2022, 4:40 PMThis build just kicked off: https://console.seed.run/fragment/workspaces/activity/stages/pr453/builds/1
Omi Chowdhury
04/12/2022, 4:41 PMabout the cli - that makes sense, will the seed CLI do the same thing with adding the status checks back on the PR?
2 Views