<@U01JB1UGDV4> got two of your issues in here
# generalt
thdxr
09/08/2021, 8:51 PM@Ross Coundon got two of your issues in here
r
Ross Coundon
09/08/2021, 8:51 PMNice one! Thank you
Ross Coundon
09/08/2021, 8:53 PMIs it 0.41.1 rather than 0.40.1?
t
thdxr
09/08/2021, 8:54 PMgood catch 😬 - updated in github
r
Ross Coundon
09/08/2021, 8:57 PMnp. The reason I noticed was that the vpc and securityGroup properties still seem to be readonly
Ross Coundon
09/08/2021, 9:02 PMIs this the correct import?
Copy code
import { FunctionProps } from '@serverless-stack/resources';t
thdxr
09/08/2021, 9:34 PMThat should be yes
r
Ross Coundon
09/08/2021, 9:35 PMIt looks like FunctionProps extends FunctionOptions which has those properties as readonly and so I'm still getting the compiler error
t
thdxr
09/08/2021, 9:37 PMah didn't realize the fields you were having trouble with were coming from cdk
r
Ross Coundon
09/08/2021, 9:38 PMyeah, seems so, indirectly
t
thdxr
09/08/2021, 9:39 PMYeah I guess you have to define your own type still - can you try this?
Copy code
type Writable = {
-readonly [K in keyof FunctionProps]: FunctionProps[K];
};thdxr
09/08/2021, 9:40 PMThe other option would be to write the code in a way where you're creating the object all at once
r
Ross Coundon
09/08/2021, 9:41 PMNeat, that works and is a more generic way of doing it than I had with my original DefaultProps type
t
thdxr
09/08/2021, 9:41 PMI'll consider doing this on our end, just need to think about why they have this as readonly in the first place
r
Ross Coundon
09/08/2021, 9:42 PMyeah, good point. I could be relying on something that is subject to change
Ross Coundon
09/08/2021, 9:44 PMThe other issue regarding setDefaultRemovalPolicy is fixed 😄
2 Views