I get a bunch of errors regarding linting I have tried to ad Serverless Stack #help

I get a bunch of errors regarding linting. I have ...

Pål Brattberg

01/26/2021, 5:02 AM

I get a bunch of errors regarding linting. I have tried to add a

.eslintignore

file with just a single

in, but lines like these spam my screen on `sst start`:

Copy code

/Users/pal/dev/peasy/node_modules/@aws-cdk/cx-api/lib/cloud-assembly.js
 0:0 warning File ignored by default. Use "--ignore-pattern '!node_modules/*'" to override

That a file is (correctly) ignored seems like TMI. Any ideas on how to supress this?

Jay

01/26/2021, 2:27 PM

Can you give me a quick sense of your dir structure? Also, do you get these errors when you run

sst build

? or is it just for

sst start

Pål Brattberg

01/26/2021, 2:44 PM

Both

start

build

Copy code

lib/
   index.js
   logger.js
   db-util.js
   etc.js
sst/
   stack-a-definition.js
   stack-b-definition.js
   common.js
services/
   service-a/
      serverless.yml
      service-a-handler.js
      service-a-handler.test.js
   service-b/
      ...
   service-z/
      ...
package.json
sst.json
.eslintignore
yarn.lock
...

Pål Brattberg

01/26/2021, 3:00 PM

I normally use standard JS for my stuff, and adding this

.eslintignore

file disrupts those settings, but I have removed standard for now

Pål Brattberg

01/26/2021, 4:12 PM

Also, if I don't add * to `.eslintignore`I'm unable to deploy due to various errors such as:

Copy code

/Users/pal/dev/peasy/services/analysis/profiler.js
 46:24 error 'process' is not defined no-undef
 58:21 error 'console' is not defined no-undef

/Users/pal/dev/peasy/lib/db.js
  11:23 error 'process' is not defined no-undef
 370:12 error 'Promise' is not defined no-undef
 425:12 error 'Promise' is not defined no-undef
 502:51 error 'Set' is not defined   no-undef

Jay

01/26/2021, 4:20 PM

We have a fix for the

process

and

console

not being defaulted on the way. But let me look at the other errors you are getting today.

Jay

01/26/2021, 4:20 PM

Can I try it in the sample repo you shared yesterday?

Pål Brattberg

01/26/2021, 4:28 PM

Let me check if it turns up there or only in my 'big' repo

Pål Brattberg

01/26/2021, 4:31 PM

If you clone that repo and run

yarn add standard

I think you might see some error, checking more now

Pål Brattberg

01/26/2021, 4:32 PM

If I do that I get another error:

Copy code

yarn sst build                                                             17:30:57
yarn run v1.22.10
$ /Users/pal/temp/sst-eu-example/node_modules/.bin/sst build
Preparing your SST app
Transpiling source
Linting source
Error: Failed to load plugin '@typescript-eslint' declared in 'BaseConfig#overrides[0]': Cannot find module '@typescript-eslint/eslint-plugin'
Require stack:
- /Users/pal/temp/sst-eu-example/__placeholder__.js
Referenced from: BaseConfig#overrides[0]
  at Function.Module._resolveFilename (internal/modules/cjs/loader.js:880:15)
  at Function.resolve (internal/modules/cjs/helpers.js:94:19)
  at Object.resolve (/Users/pal/temp/sst-eu-example/node_modules/@eslint/eslintrc/lib/shared/relative-module-resolver.js:28:50)
  at ConfigArrayFactory._loadPlugin (/Users/pal/temp/sst-eu-example/node_modules/@eslint/eslintrc/lib/config-array-factory.js:1011:39)
  at ConfigArrayFactory._loadExtendedPluginConfig (/Users/pal/temp/sst-eu-example/node_modules/@eslint/eslintrc/lib/config-array-factory.js:831:29)
  at ConfigArrayFactory._loadExtends (/Users/pal/temp/sst-eu-example/node_modules/@eslint/eslintrc/lib/config-array-factory.js:778:29)
  at ConfigArrayFactory._normalizeObjectConfigDataBody (/Users/pal/temp/sst-eu-example/node_modules/@eslint/eslintrc/lib/config-array-factory.js:719:25)
  at _normalizeObjectConfigDataBody.next (<anonymous>)
  at ConfigArrayFactory._normalizeObjectConfigData (/Users/pal/temp/sst-eu-example/node_modules/@eslint/eslintrc/lib/config-array-factory.js:664:20)
  at _normalizeObjectConfigData.next (<anonymous>) {
 code: 'MODULE_NOT_FOUND',
 requireStack: [ '/Users/pal/temp/sst-eu-example/__placeholder__.js' ],
 messageTemplate: 'plugin-missing',
 messageData: {
  pluginName: '@typescript-eslint/eslint-plugin',
  resolvePluginsRelativeTo: '/Users/pal/temp/sst-eu-example',
  importerName: 'BaseConfig#overrides[0]'
 }
}
There was a problem linting the source.
error Command failed with exit code 1.
info Visit <https://yarnpkg.com/en/docs/cli/run> for documentation about this command.

Pål Brattberg

01/26/2021, 4:33 PM

sorry,

yarn add standard -D

is more correct, but either will lead to the error shown AFAIK

Pål Brattberg

01/26/2021, 4:36 PM

And this is not the original error, but rather a new that also seems to depend on linting

Jay

01/26/2021, 6:28 PM

I see. Got it. Let me take a look at it today.

Jay

01/26/2021, 8:01 PM

The issue is with peerDependencies for the ESLint setup we are using. We'l push a fix for it today.

Pål Brattberg

01/26/2021, 8:45 PM

ah, nice to hear! Thanks for that!

Jay

01/27/2021, 2:54 AM

Just an update, the new release fixes one of the issues you were having (lint plugins not found for the cdk code) but I need to do the same for the Lambdas as well.

Jay

01/27/2021, 2:54 AM

https://github.com/serverless-stack/serverless-stack/releases/tag/v0.7.0

Jay

01/27/2021, 5:01 AM

I pushed out a patch and tested it with your repo and that seems fine — https://github.com/serverless-stack/serverless-stack/releases/tag/v0.7.1

Jay

01/27/2021, 5:02 AM

But I suspect, if you are using standard, we'll need an option to turn off linting in SST.

Pål Brattberg

01/27/2021, 8:37 AM

Awesome!

Open in Slack

Previous Next