is it safe to remove `"declaration": true,` from t...
# helps
Sam Hulick
08/12/2021, 9:51 PMis it safe to remove
"declaration": true,Sam Hulick
08/12/2021, 9:54 PMspecifically, this:
t
thdxr
08/12/2021, 9:57 PMdeclaration: true generates types so anything consuming the package can access them
thdxr
08/12/2021, 9:57 PMSafe to remove but shouldn't be necessary, let me look closer at your error later
s
Sam Hulick
08/12/2021, 9:58 PMit wants me to be incredibly explicit:
Copy code
export const main: Handler<LambdaInput, void> = ...Sam Hulick
08/12/2021, 9:58 PMwhich shouldn’t be necessary
Sam Hulick
08/12/2021, 10:00 PMTypeScript can easily take things to a level of strictness where it inhibits productivity. and this was it for me 😄
t
thdxr
08/12/2021, 10:12 PMI'm using Sentry as well I vaguely recall this let me see what I did
thdxr
08/12/2021, 10:13 PM Copy code
export const handler = Sentry.AWSLambda.wrapHandler(
async (event: APIGatewayProxyEventV2, context, callback) => {
}
)thdxr
08/12/2021, 10:13 PMfor an api gateway event
s
Sam Hulick
08/12/2021, 10:31 PMyeah, that’s what I did. even in a fresh SST project, too.. and it yells at me
t
thdxr
08/12/2021, 10:33 PMhm you have @types/aws-lambda installed?
s
Sam Hulick
08/12/2021, 10:52 PMyeah
Sam Hulick
08/12/2021, 10:52 PMyou want a reproduction on GitHub? I can put one up
t
thdxr
08/12/2021, 10:59 PMyeah that would be helpful
s
Sam Hulick
08/12/2021, 10:59 PMYou got it. Will do it when I get home
Sam Hulick
08/13/2021, 12:45 AM@thdxr here you go. I cut out almost everything and kept it pretty minimal. https://github.com/ffxsam/repro-sst-ts-error
Sam Hulick
08/13/2021, 12:45 AMI open src/services/media-processor/functions/argh.ts in VS Code and I see the TS error
Sam Hulick
08/13/2021, 1:00 AMhuh. when I remove
@types/aws-lambdaSam Hulick
08/13/2021, 1:11 AMit has to do with Yarn 2+ too I think
Sam Hulick
08/13/2021, 1:11 AMthis is probably some sort of bad package resolution on Yarn’s part. now I’m thinking this might be a Yarn bug
Sam Hulick
08/13/2021, 1:12 AMor, one of these packages is doing something that Yarn 1 doesn’t care about, and Yarn 2 is being strict about
Sam Hulick
08/13/2021, 4:10 PM@Frank @thdxr here’s what someone had to say about this issue, in case you’re curious:
t
thdxr
08/13/2021, 4:12 PMSorry forgot to reply here, yeah I saw that there were conflicting versions of @types/aws-lambda
thdxr
08/13/2021, 4:12 PMExpected yarn to be smarter about htat
s
Sam Hulick
08/13/2021, 4:12 PMyarn dedupet
thdxr
08/13/2021, 4:12 PMah nice
s
Sam Hulick
08/13/2021, 4:12 PMdoes SST include
@types/aws-lambdat
thdxr
08/13/2021, 4:13 PMI think our template might include it. It needs updating
s
Sam Hulick
08/13/2021, 4:13 PMyeah I see it in the typescript template. maybe it can be removed?
Sam Hulick
08/13/2021, 4:14 PMother packages already include it anyway
t
thdxr
08/13/2021, 4:17 PMYeah let me make an issue, this template needs to be updated in a few ways
s
Sam Hulick
08/13/2021, 4:18 PMYarn 1 was very lax with a lot of stuff. with Yarn 2+, they made it more strict. also I think they’re right,
typescriptdevDependencies