how do I add a default VPC to my functions? I have...
# helpm
Mischa Spiegelmock
12/05/2021, 2:28 PMhow do I add a default VPC to my functions? I have to create the VPC first but I’m getting
Default function props for the stack must be set before any resources have been added.f
Frank
12/06/2021, 6:09 PM
Hey @Mischa Spiegelmock, do you have any functions created before the creation of the VPC?
m
Mischa Spiegelmock
12/06/2021, 6:09 PMno functions I think just VPC. it’s at the top of my stack
f
Frank
12/06/2021, 6:09 PM
I see.
Frank
12/06/2021, 6:10 PM
@thdxr should we make the
setDefaultFunctionPropsFrank
12/06/2021, 6:11 PM
What @Mischa Spiegelmock is trying to do is quite common, I think we should allow it. What do you think?
m
Mischa Spiegelmock
12/06/2021, 6:12 PMwhat I ended up doing is subclassing Function
Mischa Spiegelmock
12/06/2021, 6:13 PMand then I do
Copy code
if (db) {
this.getAllFunctionsWithDatabaseAccess().forEach((func) => {
func.addEnvironment(EnvVars.databaseUrl, db.makeDatabaseUrl())
func.connections.allowTo(db, Port.tcp(5432), "DB access")t
thdxr
12/06/2021, 6:57 PMYeah I ran into this the other day with vpc
thdxr
12/06/2021, 6:57 PMIt's a good idea
f
Frank
12/07/2021, 2:56 AM
Sounds good. Opened an issue here https://github.com/serverless-stack/serverless-stack/issues/1124
Frank
12/07/2021, 6:50 AM
Submitted a PR. Will merge after tests pass.
m
Mischa Spiegelmock
12/07/2021, 6:56 AMamazing thank you!
f
Frank
12/07/2021, 7:58 PM
Hey guys, this is supported in v0.53.4. You can call
setDefaultFunctionProps