Hey there slightly smiling face No unique ID for functions i Serverless Stack #help

Hey there :slightly_smiling_face: [No unique ID f...

Dominik Seibold

02/03/2022, 6:40 PM

Hey there 🙂 [No unique ID for functions in

functions.jsonl

file.] [SST-version: 0.61.0] We are experiencing some weird behavior in the functions.jsonl file. Functions that are created with the same custom Construct are given the same ID in the

functions.jsonl

file. When calling the function, the source code in the

artifacts

is used where the ID is matched first. Example: We create functions in different services with the same custom CDK construct. Marked in the picture. The ID is the same “b3f05295”. However, in the artifacts folder there is only the source code for “...services/user...” for this ID. Expected behavior: Each function should get a unique ID in the

functions.jsonl

file. This way the same code will not be executed for each function. Does anyone else experience this problem?

Dominik Seibold

02/03/2022, 6:41 PM

@Fabian Ehringer

thdxr

02/03/2022, 6:41 PM

This maybe needs to be more sophisticated:

Copy code

const localId = crypto
      .createHash("sha1")
      .update(scope.node.id + id)
      .digest("hex")
      .substring(0, 8);

thdxr

02/03/2022, 6:42 PM

Think frank actually called it out at some point @Frank

Fabian Ehringer

02/03/2022, 7:19 PM

is there a workaround? can we set the ID manually?

thdxr

02/03/2022, 9:01 PM

Can I see the code in your custom construct?

thdxr

02/03/2022, 9:01 PM

I'm confused how this can evaluate to the same

Fabian Ehringer

02/03/2022, 10:21 PM

of course. I’m gonna send you the snippet as soon as I’m back on the computer

Fabian Ehringer

02/04/2022, 12:17 AM

@thdxr That’s our custom construct for this lambda. We use this construct multiple times in our project, but in different stacks and with a different handler path. The class

acme.Stack

is just a wrapper of the

sst.Stack

to provide some “metadata” like the service domain to our constructs.

Fabian Ehringer

02/04/2022, 12:24 AM

scope.node.id

sst.Function

is the id of the construct which is only unique in the parent construct, but neither in the stack nor in the app, right? Our custom construct is used multiple times with the same ID which is fine since it’s not the same stack. Using

scope.node.path

would fix it imo:

Copy code

const localId = crypto
      .createHash("sha1")
      .update(scope.node.path + id)
      .digest("hex")
      .substring(0, 8);

Fabian Ehringer

02/04/2022, 1:07 AM

@thdxr @Frank Just fyi: I just tried this by changing that line in my node modules and it seems to work for me

thdxr

02/04/2022, 1:28 AM

I should probably be using node.addr

thdxr

02/04/2022, 1:28 AM

That's the mistake

thdxr

02/04/2022, 1:28 AM

path is interesting, what does that give you?

thdxr

02/04/2022, 1:29 AM

I'll fix this tonight

Fabian Ehringer

02/04/2022, 1:29 AM

great. thanks a lot!

Fabian Ehringer

02/04/2022, 1:30 AM

path is something like

<stage>-<projectName>-<stackId>/<constructId>

Fabian Ehringer

02/04/2022, 1:31 AM

I don’t know what it would be for a nested/child stack with one or more constructs

Dominik Seibold

02/04/2022, 9:06 AM

thank you for your help @thdxr. 😉 We have now patched version 0.61.0 with your changes. This fixes the problem. This also fixes the problem when we deployed the functions. As soon as a function was called that had one of the same Ids we always got the error - ERROR Uncaught Exception {“errorType”: “Runtime.ImportModuleError”.....

thdxr

02/04/2022, 2:55 PM

Making the fix now

thdxr

02/07/2022, 2:44 PM

Took a bit to get all the tests working - just merged and released.

Open in Slack

Previous Next