Hey everyone, After upgrading to 0.69.5 i've lost ...
# helps
Stan
04/19/2022, 4:02 PMHey everyone, After upgrading to 0.69.5 i've lost the ability to automatically rebuild code after saved changes during 'sst start' mode (only stacks rebuilds, but not lambda code). Is there now some additional config to enable this?
l
Lukasz K
04/19/2022, 6:29 PM@Stan you sure you've called the function at least once after running
sst startLukasz K
04/19/2022, 6:32 PMHas to do with the functions being lazily initialized for a while now
s
Stan
04/19/2022, 6:33 PMyep, thats how i noticed the problem - lambda returned with the "old code". To make changes visible I need to stop the process and run "yarn start" again. If i remember correctly, before in terminal after saving some changes I got informations like "rebuilding infa and rebuilding code". Now I can only see "Stacks: Building changes...
Stacks: Synthesizing changes..."
Stan
04/19/2022, 6:36 PMbefore I was at 0.46.1, so didn't heard yet about lazy loading. Thanks for the hint, I will double check that
Stan
04/20/2022, 2:41 PMok, I've tested different options and it works like this - when i make some change inside lambda handler it will rebuild the changes in lambda and in imports. But when I change something in imports only, it will not rebuild at all. Is it possible to switch it off? Previous behaviour was way better, I can't imagine keeping all the code inside the lambda handler itself
l
Lukasz K
04/20/2022, 5:33 PMPretty sure that if you chat our local heroes, @thdxr, @Frank, they'll be able to work things out with ya
t
thdxr
04/20/2022, 5:34 PM@Stan this sounds like a bug - in my setup this works the way you expect
thdxr
04/20/2022, 5:34 PMCan you share with me your folder structure?
s
Stan
04/21/2022, 8:02 AMHey thdxr, folder structure is a bit unusual at first, so I can describe more in detail where things are if needed. I started from your monorepo template with yarn workspaces published previous year on github
Stan
04/21/2022, 8:15 AMIn src/microservices/aAPI i have a corresponding AApiStack.ts that contains API GW configuration. Endpoints are grouped by feature and for example user management lambdas are in src/microservices/aAPI/users/UsersLambdas.ts, endpoints definition is stored in UserEndpoints.ts and then imported to AApiStack.ts inside "routes" section of API GW.
Implementation of lambdas is stored under src/packages, so in this case UsersService.ts will implement the logic and its under src/packages/a/user/UsersService.ts this service is imported by UsersLambdas.ts.
When I make a change in UsersLambdas.ts, everything works ok, and I can see the changes made to both Lambdas.ts and Service.ts.
When I make a change only in UsersService.ts, nothing gets rebuild (well, only infrastructure) and I need to run "sst start" again.
t
thdxr
04/21/2022, 12:13 PMIf they're two different packages how are importing between them?
thdxr
04/21/2022, 12:13 PMAlso where is your main file for the stacks?
s
Stan
04/21/2022, 12:23 PMindex.ts is directly under src/
Stan
04/21/2022, 12:24 PM"src/packages/*" and "src/microservices/*" are yarn workspaces
t
thdxr
04/21/2022, 12:57 PMThis might be the issue, think we might be ignoring some of your code
thdxr
04/21/2022, 12:58 PMwe generally don't recommend mixing stacks code and application code in the same directory, even though they feel related
thdxr
04/21/2022, 12:58 PMI'll see if I can track down this issue
s
Stan
04/21/2022, 12:59 PMso you would rather put all the stack related code in root/infra and app code in root/src ?
t
thdxr
04/21/2022, 1:00 PMYeah this repo is a bit outdated but it's roughly the pattern we encourage: https://github.com/serverless-stack/graphql-stack
thdxr
04/21/2022, 1:00 PMstacks folder, and then a backend package with core for library code and functions for where things get mounted
thdxr
04/21/2022, 1:01 PMsomewhat similar to your setup
s
Stan
04/21/2022, 1:02 PMthanks, I will have a look on this one
Stan
05/19/2022, 5:55 PMHey @thdxr! I've finally found some time to do refactoring of our app. I've moved the stacks to separate folder, simplified the project structure similar to graphql example and migrated to v1, but reloading the code still does not work properly for me. I've experimented a bit and I think the problem is when you import some function from the file that is not in the same directory path. As long as the file i'm importing from is in the same directory as lambda it works ok. But if I import from the file on different path it does not reload the new content on save.
Stan
05/19/2022, 5:57 PMI will try to prepare some small project that will reproduce this behaviour over the weekend
4 Views