Hi, some general feedback after updating today to ...
# helpr
Rudi
05/25/2022, 6:16 PMHi, some general feedback after updating today to v 1.2.4 - I see this on deployment to a local dev env (non-prod)
Copy code
===============
Deploying app
===============
/home/rudi/projects/notes/node_modules/aws-cdk-lib/aws-autoscaling/lib/auto-scaling-group.d.ts (672,15): Cannot find name 'Set'. Do you need to change your target library? Try changing the 'lib' compiler option to 'es2015' or later.
670. */
671. _metrics: Set<GroupMetric>;
672. constructor(...metrics: GroupMetric[]);
Deploying stacksRudi
05/25/2022, 6:17 PMEverything deploys OK, but I do see that console output
Rudi
05/25/2022, 6:24 PMMore FYI as I work through the guide ..
Copy code
Debug session started. Listening for requests...
a7ddea91-1cdf-4051-b999-47db3f51ae94 REQUEST rudijs-notes-ApiStack-ApiLambdaPOSTnotes3B067E1B-0MSxa9UmkbFo [functions/create.main] invoked by API POST /notes
a7ddea91-1cdf-4051-b999-47db3f51ae94 RESPONSE {"statusCode":200,"body":"{\"userId\":\"123\",\"noteId\":\"905f1a60-dc57-11ec-bd09-118ca41ff572\",\"content\":\"Hello World\",\"attachment\"... 39 more characters"}
Stacks: Building changes...
Stacks: Synthesizing changes...
/home/rudi/projects/notes/node_modules/aws-cdk-lib/aws-autoscaling/lib/auto-scaling-group.d.ts (672,15): Cannot find name 'Set'. Do you need to change your target library? Try changing the 'lib' compiler option to 'es2015' or later.
670. */
671. _metrics: Set<GroupMetric>;
672. constructor(...metrics: GroupMetric[]);
Stacks: There are new infrastructure changes. Press ENTER to redeploy.t
thdxr
05/25/2022, 6:24 PMhm that's odd
thdxr
05/25/2022, 6:25 PMhaven't seen this myself yet
thdxr
05/25/2022, 6:25 PMah you're using js right?
r
Rudi
05/25/2022, 6:26 PMYep just following along the guide in JS - I plan to do it again in TS when JS complete
t
thdxr
05/25/2022, 6:26 PMhave a fix for this going to push soon
r
Rudi
05/25/2022, 6:26 PMCool .. I'll keep posting feedback if anything pops up.
t
thdxr
05/25/2022, 6:26 PMty
r
Rudi
05/25/2022, 6:27 PMit's all working, just those warnings looks like
t
thdxr
05/25/2022, 6:27 PMI don't use the JS version of our setup so it gets a little less attention
r
Rudi
05/25/2022, 6:27 PMFor sure TS is the way to go, but I wanted to just follow what's there as I'm a level 1 beginner with SST
t
thdxr
05/25/2022, 6:28 PMyeah makes sense and is helpful for us!
k
Klaus
05/25/2022, 8:59 PM@Rudi it's always good to follow what you are comfortable with. TS has it's advantages though, as it is more self documenting and warns early about potential errors. Some other bits of it can be annoying though ( especially if you try to build your own types or are just starting). Using the
:any// @ts-ignore