hey guys weird bug going on with Yarn workspaces amp SST eas Serverless Stack #sst

hey guys, weird bug going on with Yarn workspaces ...

Sam Hulick

08/11/2021, 3:44 AM

hey guys, weird bug going on with Yarn workspaces & SST. easy to reproduce.. this is my package.json at the root level of my test monorepo:

Copy code

{
  "name": "v2-microservices",
  "version": "0.1.0",
  "private": true,
  "workspaces": [
    "src/services/*"
  ],
  "dependencies": {
    "@serverless-stack/cli": "^0.37.2"
  }
}

when I run

yarn

, I see a node_modules folder pop up in

src/services/mytest/

which I don’t think is supposed to happen. no other dependencies do this.. if I remove the SST CLI package and install a bunch of other stuff, it’s fine. I’ve let one of the Yarn 2 maintainers know. not sure if this bug exists in Yarn 1

Sam Hulick

08/11/2021, 3:45 AM

package.json in `src/services/mytest`:

Copy code

{
  "name": "mytest",
  "packageManager": "yarn@3.0.0",
  "dependencies": {
    "data-api-client": "^1.2.0",
    "http-errors": "^1.8.0",
    "json-schema-to-ts": "^1.6.4"
  },
  "devDependencies": {
    "@types/http-errors": "^1"
  }
}

Frank

08/11/2021, 3:45 AM

Hey @Sam Hulick, what’s in the node_modules?

Sam Hulick

08/11/2021, 3:46 AM

Copy code

src/services/mytest/node_modules
├── http-errors
│   ├── HISTORY.md
│   ├── LICENSE
│   ├── README.md
│   ├── index.js
│   └── package.json
└── setprototypeof
    ├── LICENSE
    ├── README.md
    ├── index.d.ts
    ├── index.js
    ├── package.json
    └── test
        └── index.js

Frank

08/11/2021, 3:46 AM

I think I get it with

yarn

v1 as well, it’ has a .bin folder mostly.. nothing real

Frank

08/11/2021, 3:47 AM

hmm.. lemme give it a try in a bit

Sam Hulick

08/11/2021, 3:59 AM

https://github.com/yarnpkg/berry/issues/3266

Sam Hulick

08/11/2021, 5:59 AM

@Frank got it. it’s because

@serverless-stack/cli

requires a different version of

http-errors

than my service uses. so it has to create a node_modules folder in the service subfolder to avoid a version conflict.

Frank

08/11/2021, 6:57 PM

Oh, I thought both versions of

http-errors

should be hoisted to the root:

Copy code

/
  node_modules/
    http-errors/
    @serverless-stack/
      cli/
        node_modules/
          http-errors/

Frank

08/11/2021, 6:57 PM

I think that’s how npm and yarn v1 behaves?

Sam Hulick

08/11/2021, 6:57 PM

I suppose not 🤷‍♂️ that’s what one of the yarn 2 maintainers told me. this is normal behavior

Open in Slack

Previous Next