Is there a way to avoid type-checking over depende...
# ssta
Adrián Mouly
08/27/2021, 5:15 PMIs there a way to avoid type-checking over dependencies? Middy apparently imports x-ray, but I’m not using that.
t
thdxr
08/27/2021, 5:16 PMwhat does your tsconfig look like?
a
Adrián Mouly
08/27/2021, 5:16 PM Copy code
{
"compilerOptions": {
"target": "ES2018",
"module": "commonjs",
"lib": [
"es2018"
],
"declaration": true,
"strict": true,
"noImplicitAny": true,
"strictNullChecks": true,
"noImplicitThis": true,
"alwaysStrict": true,
"noUnusedLocals": false,
"noUnusedParameters": false,
"noImplicitReturns": true,
"noFallthroughCasesInSwitch": false,
"inlineSourceMap": true,
"inlineSources": true,
"emitDecoratorMetadata": true,
"experimentalDecorators": true,
"strictPropertyInitialization": false,
"typeRoots": [
"./node_modules/@types"
],
"paths": {
"@heyyabble/*": [
"./src/packages/*"
]
}
},
"include": [
"lib",
"src"
]
}Adrián Mouly
08/27/2021, 5:19 PMNot sure why is checking the node_modules apparently.
Adrián Mouly
08/27/2021, 5:21 PMI’m using version 0.39.0 by the way, due the problem on empty-stacks.
t
thdxr
08/27/2021, 5:26 PMthis tsconfig.json is in the same directory as sst.json ?
a
Adrián Mouly
08/27/2021, 5:50 PMYes sir.
Adrián Mouly
08/27/2021, 5:50 PMIs the only one I have.
Adrián Mouly
08/27/2021, 5:51 PMIt shouldn’t check the node_modules right?
t
thdxr
08/27/2021, 5:56 PMyeah it shouldn't that's strange
a
Adrián Mouly
08/27/2021, 5:57 PMGoing to upgrade to latest sst.
t
thdxr
08/27/2021, 5:57 PMOh this isn't a type checking error this is a compilation error. Can you add that package and see if it fixes it?
thdxr
08/27/2021, 5:57 PMa
Adrián Mouly
08/27/2021, 5:57 PMMmm.
Adrián Mouly
08/27/2021, 5:57 PMThis is a type error after I enabled type check.
Adrián Mouly
08/27/2021, 5:58 PM Copy code
"lint": true,
"typeCheck": trueAdrián Mouly
08/27/2021, 5:58 PMI had typeCheck: false
Adrián Mouly
08/27/2021, 5:58 PMDue I had several issues.
Adrián Mouly
08/27/2021, 5:58 PMAnd all worked fine with false.
Adrián Mouly
08/27/2021, 5:58 PMNow that is true, I get this error.
Adrián Mouly
08/27/2021, 5:58 PMMakes sense?
t
thdxr
08/27/2021, 6:00 PMWhat I meant by type checking error is that it's not an error coming from type issues. The way this works is if
typeCheck: truetscesbuildtsca
Adrián Mouly
08/27/2021, 6:02 PMYeah, this dependency is not installed, not sure why Middy needs it.
s
Sam Hulick
08/27/2021, 6:03 PMweird, I don’t have
aws-xray-sdkyarn why aws-xray-sdka
Adrián Mouly
08/27/2021, 6:03 PMYes, I just installed it and no errors anymore.
Adrián Mouly
08/27/2021, 6:03 PMBut well, for some reason my middy uses it.
Adrián Mouly
08/27/2021, 6:04 PMLooks like SSM-middy uses it.
s
Sam Hulick
08/27/2021, 6:04 PMahh. I was gonna say, it’s probably a middy add-on
a
Adrián Mouly
08/27/2021, 6:04 PMWhat a crap 😞
Adrián Mouly
08/27/2021, 6:06 PMIs there a way to tell the type-check to ignore some folder?
Adrián Mouly
08/27/2021, 6:06 PMBecause is throwing some errors from my React folder.
Adrián Mouly
08/27/2021, 6:07 PMLike…
Cannot find name 'Window'.Adrián Mouly
08/27/2021, 6:07 PMLooks like
react_routerAdrián Mouly
08/27/2021, 6:08 PMI think it’s because my
tsconfigs
Sam Hulick
08/27/2021, 6:08 PMdo you have this in your tsconfig’s
compilerOptions Copy code
"lib": ["ESNext", "DOM"],a
Adrián Mouly
08/27/2021, 6:09 PMI have
es2018Adrián Mouly
08/27/2021, 6:09 PMOk, adding
domAdrián Mouly
08/27/2021, 6:09 PMIs that ok? I don’t want my lambdas to be affected somehow.
s
Sam Hulick
08/27/2021, 6:10 PMsure, it works ok for me. I don’t think it’ll affect building the code
a
Adrián Mouly
08/27/2021, 6:10 PMOk, hopefully, that’s the only concern I have when merging frontend and backend, haha.
Adrián Mouly
08/27/2021, 6:10 PMIt’s all TS .. but well.
t
thdxr
08/27/2021, 6:13 PMI'm finally working on my opinionated typescript starter which should help situations like this
thdxr
08/27/2021, 6:13 PMhopefully will have it done today
a
Adrián Mouly
08/27/2021, 6:13 PM👍
Adrián Mouly
08/27/2021, 6:13 PMThanks guys.
2 Views