We had a discussion in here a little while ago abo...
# sstr
Ross Coundon
09/08/2021, 2:36 PMWe had a discussion in here a little while ago about using app.setDefaultFunctionProps to set vpc and security group values by passing a callback function.
The way we'd been doing it has broken with the most recent release.
We used to be able to define our own type to represent the props that were returned. In the new version the TypeScript compiler complains that what we're returning isn't of type FunctionProps.
If we change to the latter version in the snippet it now complains that we cannot assign to props.vpc or props.securityGroups because they're read-only
t
thdxr
09/08/2021, 2:40 PMThis is likely because I narrowed the type of
runtimethdxr
09/08/2021, 2:40 PMthat's probably what is preventing your old way from working
thdxr
09/08/2021, 2:41 PMYou should be able to fix by defining your DefaultProps like this
Copy code
type DefaultProps = {
runtime: FunctionProps["runtime"]
}thdxr
09/08/2021, 2:41 PMThat said - we should probably not be setting those fields to readonly, don't think that makes sense for a type we expect others to use
thdxr
09/08/2021, 2:43 PMWas that why you were specifying your own type? To get around the readonly issue?
r
Ross Coundon
09/08/2021, 2:44 PMYeah, I should have reported it then
t
thdxr
09/08/2021, 2:44 PMI made an issue to fix that type. Let me know if updating the typing on
runtimeFunctionProps["runtime"]r
Ross Coundon
09/08/2021, 2:48 PMyeah, that works, thank-you