https://serverless-stack.com/ logo
#sst
Title
# sst
d

Derek Kershner

12/13/2021, 6:04 PM
Just created an issue, should be a fairly quick fix: https://github.com/serverless-stack/serverless-stack/issues/1151 Perhaps I am missing something, but this is causing me some testing headaches.
f

Frank

12/13/2021, 9:09 PM
Thanks @Derek Kershner. @thdxr what do you think about devDep vs peerDep?
t

thdxr

12/13/2021, 9:10 PM
I do think those should be peer deps
d

Derek Kershner

12/13/2021, 9:12 PM
in my experience, peerDeps should only be for things needed at buildtime (as opposed to dev time), so something like
jest
wouldnt be needed. But you guys might also have a need to run tests in some builds, which would indeed require a peerDep. Good with either, just looking for more control over my OTHER test envs.
my only request would be that peerDeps use
>=
rather than
^
(so something like Jest 27 qualifies).
t

thdxr

12/13/2021, 9:18 PM
yeah most peerDeps would also be listed as devDeps for us
but things like typescript, jest, eslint should be peer