<https://github.com/serverless-stack/serverless-st...
# sst
d
https://github.com/serverless-stack/serverless-stack/pull/1276 @thdxr and @Frank, we had some conversation regarding dev/peer dependencies, I did my best to change only the ones that give me the most trouble, but am open to your thoughts and can change directions. As i update 40+ apps to CDK v2, this is...on my mind. šŸ™‚
t
Thanks for doing this! I'll review this week and get it working
40+ apps wow
Are they all using SST already?
d
some are just CDK. depends on whether they make use of something SST makes. We have leaned very heavily into SST, though, and it represents all of our APIs, background jobs, and webapps (those three categories maybe account for about 30 of the apps). It's a large project, and we prioritized laying down infrastructure from day one. For your guys reference, we make very heavy use of
Api
,
NextJsSite
,
Function
,
Cron
.
RE:
peerDependencies
, I checked what Vercel does with Next.js because I was curious, and they do Linting and Type-Checking as part of their build. They actually list those items in no way that I can see. This can make some sense, as
peerDependencies
are generally only filled by
dependencies
in the installing project, and things like ESLint, TypeScript, Jest are usually
devDependencies
.
Regardless, thanks for taking the time @thdxr, I am unlikely to be the last to experience these headaches (even though I appear to be the first!) šŸ™‚
I just hit another snag...
apollo-server-core
is now having a version clash...
t
I don't even think we use that anymore I can strip it out
d
that one looks like it might not be you guys, but rather apollo itself it's the CLI bringing in
apollo-server-express
v2 (im v3)
definitely not my first rodeo with node dependency issues, would just like to do the best we can
As i wrap up my last conversion, I had very little issues, besides: • The apollo dependency clash. • The issue you fixed in 0.60.4. • https://serverless-stack.slack.com/archives/C01JG3B20RY/p1642092806281200
all told, not bad at all