It looks like SSO support is landing in the CDK wi...
# sst
r
It looks like SSO support is landing in the CDK with the next minor! https://github.com/aws/aws-cdk/pull/19454 Would be awesome is SST support landed shortly after :3
f
got it @Richard Simpson. Bump up the priority on this https://github.com/serverless-stack/serverless-stack/issues/1552
r
Looking at the changes the CDK made and SST's codebase, it looks like the changes aren't too terrible if ya'll'd accept a contribution on this front?
f
that’d be awesome, lemme just share what are we doing real quick: 1. At the beginning of an sst command, we try to sort out the AWS credentials here https://github.com/serverless-stack/serverless-stack/blob/master/packages/cli/bin/scripts.js#L221-L232 2. And that in turn this function gets called https://github.com/serverless-stack/serverless-stack/blob/master/packages/core/src/aws-sdk/awscli-compatible.ts
r
Yup! Managed to track it down. Would it be amiss if I added
--profile
support while I was here? Something that's always bothered me being missing haha
f
That file in step 2 is a straight copy from the CDK codebase. I think we can just apply the same changes in their PR https://github.com/aws/aws-cdk/pull/19454/files#diff-4fd56f40e997bba9c9cc26cf10596a241dd7110efa473a67de24d28a01a9946e
Yup go for it!
r
Looks like this will also fix support for
credential_process
đŸ¥³
s
Yesss!
Since SST is doing it's own credential pipeline in place of CDK's, this will theoretically fix SSO/Credential Process without having to bump the CDK AFAIK
f
Hey guys, this is released in 0.69.3. Thanks for putting this together so quickly @Richard Simpson!