https://www.puppet.com/community logo
Join Slack
Powered by
<@U2PU8Q22G> hi hi! Can you take a look at some of...
# forge-modules
b
@ghoneycutt hi hi! Can you take a look at some of those patroni PRs? Or are you interested in migrating the module to vox pupuli?
g
Will do! I am planning to migrate to VP. For me, this was a dependency for running Sensu in a HA way and Sensu is no more so I don’t have a direct use for this anymore as I’m not managing Postgres.
b
ah perfect. You should have permissions to migrate the git repo to vox pupuli. if that doesn't work, let me know!
g
@bastelfreak This appears to be changing the current functionality, otherwise looks great. https://github.com/tailored-automation/puppet-module-patroni/pull/41
I merged a change with a few new params, would you mind rebasing and please adding those.
That’s it for open PR’s that can be merged. The rest need tests added before they can be merged. If you have time to help with those that would be much appreciated. Would like to get the open PR’s closed out before migrating.
b
Thanks! I commented on the PR and rebased it, I think it's ready to merge
g
Noticed there are still a bunch of 
String
types in there. Is that by your design or just changing some of these that you use?
b
I just changed those were I was pretty sure that it isn't a breaking change
g
I went ahead and changed the rest, would you mind giving it a review at https://github.com/tailored-automation/puppet-module-patroni/pull/43
I kept 
Array[String] $foo = [],
when it already had an empty array as the default value.
Open in Slack
PreviousNext
Powered by