This message was deleted.
# forge-modules
s
This message was deleted.
s
I also don't like this. My personal view on this is that when you write test, instead of testing each parameter in isolation if you have a tests with only the required parameters set, and another with all parameters, set you can check if the whole content match some expectation, and that can catch most of such issues (and speed-up tests dramatically). But testing many things in a single test is not a best practiceโ€ฆ ๐Ÿ˜’
I learned to live with these annoyances, but if you want to fix these in PR I will be more than happy to see them merged ๐Ÿ˜‰ This attention to details is IMHO a good thing to do.
v
It's a weird case here, erb was switched to epp and somehow extra line is present
It was driving me nuts when ntp servers bounced
luckily chronie module is more careful
s
I guess I think I am a little too nerdy to complain ๐Ÿ˜…, but in fact such changes are not good to check if a module does change a catalog, and I would consider PR to fix bugfixes that deserve a quick patch version .
I think I saw this extra line a few weeks ago (i was using a specific commit before the release of 12.0.0). Is this the only change you saw?
v
yep, it changed every single vhost file for me
s
Yes, but all caused by a single extra new line in the same template? So a single fix to do?
v
it should, but I don't understand why it wasn't an issue before ๐Ÿ™‚
erb very much like epp
and yet, epp has extra line
s
has not started to look yet
v
Ah, missed that
testing
s
No change comparing to 11.1.0 on my test machine
v
I trust you then ๐Ÿ™‚
s
Yeah, but my conf is quite minimal so better double-check in case there is another missing dash somewhere ๐Ÿ˜‰
v
sure
yep, this works, I approved PR
๐Ÿ‘ 1