This message was deleted.
# office-hourss
Slackbot
05/30/2023, 2:17 PMThis message was deleted.
y
Yury Bushmelev
05/30/2023, 2:20 PMhttps://github.com/puppetlabs/pdk-templates/blob/main/README.md#rakefile
See
linter_optionsYury Bushmelev
05/30/2023, 2:20 PMYury Bushmelev
05/30/2023, 2:20 PMI’d start here at least 🙂
j
Jordan Breen
05/30/2023, 2:27 PMthanks @Yury Bushmelev
😉 1
Jordan Breen
05/30/2023, 2:27 PMlet me take a look @bastelfreak
Jordan Breen
05/30/2023, 2:28 PMbut right now my understanding is that is the only way to do it ^^
b
bastelfreak
05/30/2023, 2:28 PMif the parameter_documentation / parameter_types checks are enabled by default I dont mind it
j
Jordan Breen
05/30/2023, 2:31 PMJordan Breen
05/30/2023, 2:32 PMwould look to be enabled by default
b
bastelfreak
05/30/2023, 2:32 PMah neat
bastelfreak
05/30/2023, 2:32 PMI jsut wasn't sure. at vox pupuli we made it opt-in
j
Jordan Breen
05/30/2023, 2:32 PM💯 🙂
c
Craig Gumbley
05/30/2023, 2:39 PMquick drive-by from me
Craig Gumbley
05/30/2023, 2:39 PMthis is kind of open for review too
Craig Gumbley
05/30/2023, 2:40 PMafaik there is no “method to the madness” and there are some checks that are disabled in spec_helper (i think)
Craig Gumbley
05/30/2023, 2:40 PMits not very visible though
Craig Gumbley
05/30/2023, 2:40 PMwhich is something i’d like to resolve
Craig Gumbley
05/30/2023, 2:41 PMalso
Craig Gumbley
05/30/2023, 2:41 PMCraig Gumbley
05/30/2023, 2:42 PMj
Jordan Breen
05/30/2023, 2:44 PM🙌
b
bastelfreak
05/30/2023, 2:44 PMhttps://github.com/voxpupuli/modulesync_config/blob/master/config_defaults.yml#L43 we disabled the two checks I mentioned because they require some work on our modules. more and more of our modules opt-in to them. We render that to Rakefile and .puppet-lint.rc
👀 1
c
Craig Gumbley
05/30/2023, 2:45 PMah ok looks like we have inherited that part from module_sync then
b
bastelfreak
05/30/2023, 2:46 PMhttps://github.com/voxpupuli/modulesync_config/blob/master/moduleroot/.puppet-lint.rc.erb +ah no, only to the puppet-lint.rc. The rake tasks reads that by default