This message was deleted.
# puppet-enterprises
Slackbot
05/12/2023, 7:59 AMThis message was deleted.
b
bastelfreak
05/12/2023, 8:03 AMwhy do you need different logic in the modules?
bastelfreak
05/12/2023, 8:03 AMis that actually a requirement or do you only use it to set different default values
m
Moe
05/12/2023, 8:04 AMMaybe someone says that a server in production needs an additional file which the nonprod server does not
Moe
05/12/2023, 8:05 AMBut yes you're right, we don't always need different logic and have modules with branches for production and nonprod just for the sake of it.
I want to go away from this principle.
b
bastelfreak
05/12/2023, 8:05 AMso from the perspective of one of your teams, they have a production environment with important systems and a non-prod environment with less important systems
bastelfreak
05/12/2023, 8:06 AMbut from a puppet point of view, that's not the case. you don't have the less-important env to test puppet code. it's used to test an application I guess? So puppet needs to work on both environments, it just does different things
bastelfreak
05/12/2023, 8:06 AMis that roughly correct?
bastelfreak
05/12/2023, 8:07 AMif so, I would not implement such an environment logic in the modules, but rather features flags like $manage_file_foo in the mentioned module. and you manage that parameter via hiera. it's true by default for nonprod and false for prod
bastelfreak
05/12/2023, 8:07 AMthat allows you to use the same branch/commit/tag of a module in both environments
bastelfreak
05/12/2023, 8:08 AMand if that works you can think about if you actually need two puppet code environments
m
Moe
05/12/2023, 8:10 AMYes that's correct! Interesting I haven't thought about this one yet. This might be something to consider. Oh and I totally left out Puppet profiles, which of course also have production and nonprod named branches just because.
b
bastelfreak
05/12/2023, 8:10 AMthink about if that's actually required or if it just makes stuff more confusing
m
Moe
05/12/2023, 8:11 AMFeature flags sound good, but I worry from knowing the people in my organization and the servers they run that this could get out of hand.
b
bastelfreak
05/12/2023, 8:11 AMand now the branches dont get out of hand?
bastelfreak
05/12/2023, 8:11 AMhow often do you merge from one branch to another? how big is the gap between nonprod and prod?
bastelfreak
05/12/2023, 8:12 AMmost customers I support end up with two (or more) completely different environments over time because most of their stuff doesn't understand git enough to do merges/cherry-picks, so we try to reduce the git complecity
👍 1
m
Moe
05/12/2023, 8:13 AMOh yes, it is absolutely confusing because you have servers which are to some IT teams "production" but actually run in the nonprod datacenter and are thus a nonprod system in the puppet environment but the module and profile are on a production branch.
It's SO complicated that I want to just rip all this out.
Disclaimer: I inherited this setup a couple years ago and am now rebuilding everything from the ground up
Moe
05/12/2023, 8:14 AMYup, the people here also don't want to learn git and the ways on how to bring in changes etc. I'm happy if they do Pull Requests. But most just edit online on Bitbucket.
b
bastelfreak
05/12/2023, 8:15 AMyeah rip it out 😄
bastelfreak
05/12/2023, 8:15 AMon which puppet version are you
m
Moe
05/12/2023, 8:15 AMRegarding merging: We don't
Because we have logic in each branch which cannot be brought over to the other because this would break the server
Moe
05/12/2023, 8:15 AMWe'll be doing 7.24 with latest PE
b
bastelfreak
05/12/2023, 8:15 AMokay
bastelfreak
05/12/2023, 8:16 AMah so if people want to implement something for both environments they have to do it twice?
m
Moe
05/12/2023, 8:16 AMYes
b
bastelfreak
05/12/2023, 8:16 AMah well 😄
m
Moe
05/12/2023, 8:16 AMAnd then they forget to do it on the other branch
Moe
05/12/2023, 8:17 AMSo I want to have logic in one branch where they can do exactly this in the SAME place so they don't have to think about it
Moe
05/12/2023, 8:17 AMThey can still to PRs (which is good for reviews etc)
Moe
05/12/2023, 8:18 AMAll this is a huge PITA and I hate everything about it 😄
b
bastelfreak
05/12/2023, 8:18 AMI would try to get rid of the multiple branches and reduce that
m
Moe
05/12/2023, 8:23 AMAgreed. This is the first action I'm taking. The layer of complexity is too much and does not bring any benefits.
b
bastelfreak
05/12/2023, 8:23 AMyep
bastelfreak
05/12/2023, 8:24 AMin case you need and puppet or git training for the team, let me know 😄
m
Moe
05/12/2023, 8:26 AMHeh 😄 You say this so lightly
b
bastelfreak
05/12/2023, 8:26 AM😄
m
Moe
05/12/2023, 8:27 AMThanks for your feedback and input! 🙂
b
bastelfreak
05/12/2023, 8:29 AMsure, your welcome
bastelfreak
05/12/2023, 8:29 AMmay I ask how many nodes you have? any performance issues?
m
Moe
05/12/2023, 9:11 AMSure, so we have roughly 500 nodes and not really any performance issues. Why do you ask?
b
bastelfreak
05/12/2023, 9:13 AMah just curious. many people report performance problems
m
Moe
05/12/2023, 9:14 AMInteresting. Long run times or other things?
b
bastelfreak
05/12/2023, 9:15 AMA mix of everything 😄
m
Moe
05/12/2023, 9:18 AMAh nice 😄