This message was deleted.
# office-hourss
Slackbot
05/09/2023, 2:01 PMThis message was deleted.
👀 1
j
Jordan Breen
05/09/2023, 2:02 PMhey @Pat Riehecky
Jordan Breen
05/09/2023, 2:02 PMwe'll need the failing spec tests addressed before moving forward
p
Pat Riehecky
05/09/2023, 2:02 PMI'm not sure how to fix it...
j
Jordan Breen
05/09/2023, 2:05 PMlemme see whats happening
p
Pat Riehecky
05/09/2023, 2:06 PMhttps://github.com/puppetlabs/puppetlabs-vcsrepo/actions/runs/4872638382/jobs/8691140146?pr=586#step:6:21 seems to be where it is grumpy
j
Jordan Breen
05/09/2023, 2:07 PMAh i see now..
Jordan Breen
05/09/2023, 2:09 PMInterested in the approach you opted for to exclude redhat from the tests.
something that might be easier to read/cleaner way of executing is updating
next if OS_FAMILY_WITHOUT_BZR.include?(os[:family])next unless os[:family] != 'RedHat'Jordan Breen
05/09/2023, 2:10 PMshould help eliminate the error whilst helping the readability 🙂
p
Pat Riehecky
05/09/2023, 2:10 PMIn theory I've pushed up that change
j
Jordan Breen
05/09/2023, 2:11 PMkay, i've approved the tests fingerscrossed
p
Pat Riehecky
05/09/2023, 2:11 PM❤️
j
Jordan Breen
05/09/2023, 2:13 PMcouple of rubocop errors
Jordan Breen
05/09/2023, 2:13 PMall pretty minor
Jordan Breen
05/09/2023, 2:16 PMhopefully can be autocorrected with
bundle exec rubocop -Ap
Pat Riehecky
05/09/2023, 2:17 PMAlas,
Lint/LiteralAsConditionj
Jordan Breen
05/09/2023, 2:20 PMtwo secs, im going to pull this down @Pat Riehecky
Jordan Breen
05/09/2023, 2:34 PMokay cool, spotted the issue.
This should work
next if os.match?('redhat')redhat-7-x86_64p
Pat Riehecky
05/09/2023, 2:34 PMWill that work with things like alma/rocky/fedora?
j
Jordan Breen
05/09/2023, 2:35 PMyes 🙂 alma and rocky won't match that value and will execute
Jordan Breen
05/09/2023, 2:36 PMverified this there now 🙂 cant speak for Fedora unfortunately
Jordan Breen
05/09/2023, 2:36 PMbut I would assume it is OK as well
p
Pat Riehecky
05/09/2023, 2:36 PMAlas, alma/rocky/fedora don't have the
bzrj
Jordan Breen
05/09/2023, 2:37 PMah... spanner in the works. well the condition will need updated to match their values passed as
osJordan Breen
05/09/2023, 2:44 PMalma follows the pattern
almalinux-...rocky-Jordan Breen
05/09/2023, 2:44 PMtested and the following pattern works
next if os.match?('redhat|almalinux|rocky')p
Pat Riehecky
05/09/2023, 2:45 PMI think I've got it updated in future proof mode (if fedora gets added at some point)
j
Jordan Breen
05/09/2023, 2:46 PM👀
Jordan Breen
05/09/2023, 2:48 PMgot green specs 🤞
Jordan Breen
05/09/2023, 2:49 PMalthough it does seem to be running on those OS
Jordan Breen
05/09/2023, 2:50 PMp
Pat Riehecky
05/09/2023, 2:51 PMhow odd...
j
Jordan Breen
05/09/2023, 2:56 PMos_facts[:family]p
Pat Riehecky
05/09/2023, 2:56 PMboo
Pat Riehecky
05/09/2023, 2:56 PMI'll just drop the
bzrPat Riehecky
05/09/2023, 2:57 PMI don't actually use it
j
Jordan Breen
05/09/2023, 2:57 PMthis does work and skips the OS's
next if os.match?('redhat|almalinux|rocky')Jordan Breen
05/09/2023, 2:57 PMbut only a suggestion
Jordan Breen
05/09/2023, 2:57 PM🙂
p
Pat Riehecky
05/09/2023, 2:57 PMThere is also Amazon Linux, Oracle, Scientific, and a few others
j
Jordan Breen
05/09/2023, 2:58 PMyeah.. in that case it would be better to match the OS you want to test rather than exclude. But yeah, that can get messy quickly
p
Pat Riehecky
05/09/2023, 3:00 PMIn theory this will pass
r
rusty
05/23/2023, 9:03 PMWhy not match on family and just skip all rhel-like?