This message was deleted.
# office-hourss
Slackbot
05/02/2023, 2:03 PMThis message was deleted.
👀 1
g
Gavin Patton
05/02/2023, 2:21 PMPR looks good. Your rebase just brought in the new Rubocop checks from our Puppet 8 support work. Shouldn't be too tough a fix
Gavin Patton
05/02/2023, 2:21 PMi'll merge when you fix those
p
Pat Riehecky
05/02/2023, 2:21 PM❤️
Pat Riehecky
05/02/2023, 2:25 PMI do wish rubocop would say which file it is upset with
Pat Riehecky
05/02/2023, 2:28 PM Copy code
Error: unrecognized cop or department RSpec/NoExpectationExample found in .rubocop_todo.yml
Did you mean `RSpec/RepeatedExample`?Pat Riehecky
05/02/2023, 2:28 PMAny ideas?
g
Gavin Patton
05/02/2023, 2:29 PMhmm let me check
Gavin Patton
05/02/2023, 2:33 PMwhat gives you that error?
Gavin Patton
05/02/2023, 2:33 PMi'm not seeing it
p
Pat Riehecky
05/02/2023, 2:33 PM Copy code
rubocop -A
Error: unrecognized cop or department RSpec/NoExpectationExample found in .rubocop_todo.yml
Did you mean `RSpec/RepeatedExample`?Pat Riehecky
05/02/2023, 2:33 PM Copy code
rubocop -v
1.50.2g
Gavin Patton
05/02/2023, 2:34 PMthat rubocop version doesn't seem right
Gavin Patton
05/02/2023, 2:34 PMafter you rebased have you run
bundle installGavin Patton
05/02/2023, 2:35 PMmaybe
rm -rf Gemfile.lock .bundlebundle install --path .bundlep
Pat Riehecky
05/02/2023, 2:37 PM Copy code
[riehecky@leibniz puppetlabs-vcsrepo]$ .bundle/ruby/3.2.0/bin/rubocop -A spec/
Error: unrecognized cop or department RSpec/NoExpectationExample found in .rubocop_todo.yml
Did you mean `RSpec/RepeatedExample`?
[riehecky@leibniz puppetlabs-vcsrepo]$ .bundle/ruby/3.2.0/bin/rubocop -v
1.50.2d
Dr Bunsen Honeydew
05/02/2023, 2:37 PMSee the
puppetlabs-vcsrepop
Pat Riehecky
05/02/2023, 2:37 PMhmmmm
g
Gavin Patton
05/02/2023, 2:38 PMtry
bundle exec rubocopGavin Patton
05/02/2023, 2:39 PMbundle exec rubocop -ap
Pat Riehecky
05/02/2023, 2:39 PMThat seems to run 🙂
g
Gavin Patton
05/02/2023, 2:40 PMnice!
p
Pat Riehecky
05/02/2023, 2:42 PMI fear I may not know enough ruby to fix the remaining errors....
g
Gavin Patton
05/02/2023, 2:44 PMlet's see
j
Jordan Breen
05/02/2023, 2:57 PMHey @Pat Riehecky 👋 can you run a
bundle exec rubocop --auto-gen-configp
Pat Riehecky
05/02/2023, 3:02 PM Copy code
[riehecky@leibniz puppetlabs-vcsrepo]$ bundle exec rubocop --auto-gen-config
Phase 1 of 2: run Layout/LineLength cop (skipped because the default Layout/LineLength:Max is overridden)
Phase 2 of 2: run all cops
Inspecting 41 files
..CC.WCCWWWCCCCCCCCCCCCCCCCC...C..CCCCCCC
41 files inspected, 433 offenses detected, 18 offenses autocorrectable
Created .rubocop_todo.yml.d
Dr Bunsen Honeydew
05/02/2023, 3:02 PMSee the
puppetlabs-vcsrepoj
Jordan Breen
05/02/2023, 3:04 PMOkay Cool. Looks like the main cops it was complaining about (
RSpec/ContextWordingRSpec/NoExpectationExampleRSpec/DescribeClassp
Pat Riehecky
05/02/2023, 3:05 PMpushed
j
Jordan Breen
05/02/2023, 3:07 PM👍
p
Pat Riehecky
05/02/2023, 3:20 PMHmmm, looks like
bzrj
Jordan Breen
05/02/2023, 3:23 PMyou can confine tests to only run on certain OS's using
if: os[:family] != 'rhel'Jordan Breen
05/02/2023, 3:23 PMor something similar
Jordan Breen
05/02/2023, 3:23 PM🙂
p
Pat Riehecky
05/02/2023, 3:40 PMIn theory I've got a check in for that pushed up just now, in practice I don't totally understand what rubocop turned it into...