Puppet Community

Hi, what version of PE were you on before?

I'm noticing it with a change from the puppet 6 agent to the puppet 7.20 agent against pe 2021.7.1

I would start by checking this page: <https://puppet.com/docs/pe/2021.7/osp/upgrading-from-puppet6-to-puppet7.html>

puppet facts diff doesn't report the legacy facts at all

Generation of legacy facts can be disabled in Puppet 7 using the `include_legacy_facts` setting.

But, that still defaults to `true`. It might flip to `false` in Puppet 8 --- but that's a next year thing.

So, there's no reason items that depend on legacy facts should have stopped working after upgrading Puppet 6 -&gt; Puppet 7.

Unless that setting was somehow flipped on.

missing gems in puppet 7 agent install which is a new Ruby that some facts depend on? That said shouldn't affect legacy facts, but might custom factgs.

Ah yeah. That's ^^ a good idea.

Upgrading between major versions of Puppet means a new Ruby version and Ruby separates gemsets out by version.

What I'm seeing is that a class that has the values for parameters set in controlrepo/data/os/OpenSUSE.yaml aren't getting found when I upgraded the agent from 6.28 to 7.20

and the line in hiera.yaml is
"os/%{::osfamily}.yaml"

```Error: Could not retrieve catalog from remote server: Error 500 on SERVER: Server Error: Evaluation Error: Error while evaluating a Function Call, Class[Profile::Server::Authentication]:
  expects a value for parameter 'duo_config_accept_env_factor'```
the profile::server::authentication class does not specify any defaults for that parameter

I believe I have found the error:
```#puppet 6 agent
facter -p os.name
OpenSuSE

# puppet 7 agent
facter -p os.name
openSUSE```
I needed to be more careful about running `puppet facts diff` on the server in question (and not just a random system). <@U02K5JF1UV6> had the right answer.

you are not only referencing a legacy fact, you do it as a top scope variable. thats basically double not-best-practice

I believe there is a FACT ticket due to Facter 4 reporting the suse name differently

yeah, old code bases have cruft :disappointed: