https://www.puppet.com/community logo
Join Slack
Powered by
# testing
  • b
    This has probably more to do with your rspec-puppet version and how you run the tests
  • j
    i'm using what comes with PDK 3.5.1, running 
    pdk test unit -v --tests=spec/classes/blah_spec.rb
  • j
    Copy code
    $ pdk bundle exec rspec --version
pdk (INFO): Using Ruby 3.2.8
pdk (INFO): Using Puppet 8.10.0
RSpec 3.13
  - rspec-core 3.13.5
  - rspec-expectations 3.13.5
  - rspec-mocks 3.13.5
  - rspec-support 3.13.6
  • b
  • j
    so how does one override the values of 
    servername
    , 
    serverip
    , and 
    serverversion
    ?
  • j
    back in PE2018 i was able to do this, but it's not having any effect now:
    Copy code
    let(:node_params) do
    {
      'serverversion' => '1.2.3' ,
      'servername'    => '<http://unit-test.domain.xyz|unit-test.domain.xyz>' ,
    }
  end
  • b
    I spend so much time to unify it to and now you want to change it 😞
  • b
    I think it always uses the values from the facts you set
  • b
    networking.fqdn and networking.ip
  • j
    wouldn't that set the hostname and IP of the machine being configured, rather than the machine where the compiler is running?
  • b
    both
  • j
    so then how does one test whether the catalog is being built for a machine OTHER THAN the puppet server itself?
  • b
    I'm not sure if I understand the question
  • j
    FWIW a lot of the files i generate include a "This file was generated by Puppet on `pe-server.example.com`" header, that needs to include the name of the puppet server, not the name of the machine whose catalog is being compiled.
  • b
    this is a bad approach as soon as you have multiple compilers. and the report already knows who compiled the catalog
  • j
    in the real world, the puppet server is almost always NOT the same as the name of the machine whose catalog is being built. i can use 
    let(:node) { '<http://target.example.com|target.example.com>' }
    to set the name of the machine whose catalog is being built, i need to be able to set the name of the puppet server which is building the catalog.
  • b
    I'm not sure if there's an option for that right now
  • b
    but I'm also cooking dinner and don't work for Perforce
  • j
    there was in PE2018
  • b
    I don't think so
  • b
    There was an option in older rspec-puppet versions
  • b
    your PE version has nothing to do with the unit tests / testsetup
  • j
    like ... the older rspec-puppet version that was part of PDK back in the PE2018 days maybe?
  • b
    yes. We removed that a long long time ago
  • b
    mhm, node_params is still a thing
  • j
    okay, well ... i'm just going to say it, whoever made the decision to remove it, made a bad decision.
  • b
    I say this just exposes a flaw in your code 😄
  • b
    https://github.com/puppetlabs/rspec-puppet/blob/main/lib/rspec-puppet.rb#L43 is still around, but I don't think you can set the server facts with it
  • b
    https://github.com/puppetlabs/rspec-puppet/pull/73 not sure why it was removed it. not sure if there was a config option in puppet < 7 to configure it within puppet
  • j
    question ... running 
    pdk validate
    returns this error
    Copy code
    pdk (WARNING): puppet-lint: class parameter with String type defaults to empty string
    on this line in a class's parameter list
    Copy code
    String $xyz = '' ,
    ... removing the 
    = ''
    makes 
    puppet-lint
    happy, but it changes the parameter from "optional with a default value" (which is what i need in this case) to "required" (which is NOT what i need)
    b
    k
    +2
    • 5
    • 11