Has anyone had issues with subscriptions not firin...
# orm-helpr
rem
02/20/2019, 4:01 PMHas anyone had issues with subscriptions not firing? I'm using them to trigger welcome emails for users, but inconsistently don't always fire.
h
Harshit
02/20/2019, 4:02 PMAre you talking about subscriptions in prisma.yml?
r
rem
02/20/2019, 4:04 PMNo, using
await prisma.$subscribeh
Harshit
02/20/2019, 4:09 PMoh okay, might be related to https://github.com/prisma/prisma/issues/3950
Any reason why are you not firing the email just after creating the user in the createUser mutation
r
rem
02/20/2019, 4:37 PM@Harshit I figured that subscriptions were a nice decoupled way of handling it (assumed I could change the user's state in other ways - unsure how as yet - and the subscription would handle it)
rem
02/20/2019, 4:38 PMIf it were that bug (the github issue) wouldn't the await return with
done: truerem
02/20/2019, 4:41 PM(turning on browser notifications - I keep missing your replies!)
h
Harshit
02/20/2019, 4:43 PMCan you please share some code?
r
rem
02/20/2019, 4:46 PMsure - one sec
rem
02/20/2019, 4:51 PM@Harshit sorry - multiple slack windows! https://gist.github.com/remy/f6969fbfcfc95948d4310498bfd51ab4 - the
if (done)rem
02/20/2019, 4:51 PMSo it seems like the
$subscriptionh
Harshit
02/20/2019, 4:53 PMLooks like the while loop might be causing this, you should use for...await here
Harshit
02/20/2019, 4:54 PM Copy code
for await (let data of createUserIterator) {
// do stuff here
const { done, value: user } = data;
}r
rem
02/20/2019, 5:01 PMIn theory that's the same code
rem
02/20/2019, 5:01 PMExcept I don't need to transpile to get support for it
h
Harshit
02/20/2019, 5:05 PMI don't think you need to transpile it and I have got into trouble with while loop as it is infinite loop
Harshit
02/20/2019, 5:05 PMit can cause potential leaks
r
rem
02/20/2019, 5:12 PMhmm. I've got a feeling that when I ran it with Jest it complained that it couldn't run that code.
h
Harshit
02/20/2019, 5:13 PMI think these are not equivalent. Also, this is supported in node v10
Harshit
02/20/2019, 5:14 PMplease check you node version, I think you should use node v10 as it the latest LTS
r
rem
02/20/2019, 5:14 PMYep - using 10
rem
02/20/2019, 5:14 PM(damn notifications aren't working in this slack window - sorry for delayed replies!)
rem
02/20/2019, 5:15 PMYea, 10.14.1
rem
02/20/2019, 5:15 PMI'll double check jest
rem
02/20/2019, 5:16 PMhuh, jest is working. I really can't remember what it was that was complaining about that syntax, but I'll keep using it for now.
rem
02/20/2019, 5:16 PM(the syntax you suggested). If the socket is dropped, will it have
done: trueh
Harshit
02/20/2019, 5:17 PMyes, it is based on the next value
Harshit
02/20/2019, 5:18 PMthis is the proper way to do a iteration over an async iterable