hello, i have a column in postgres with boolean values. now when I apply a boolean filter with prisma on that column it doesnt work as intended

draft:
	typeof draft !== 'undefined'
	? {
		equals: draft // either true or false
	}
	: undefined

the value

draft

is either a

true

or a

false

. when the value is

true

it filters correctly and only shows me records with draft value set to

true

, but with

false

it shows me all records including the ones with

true

instead of only record with the draft value set to

false

. How could I fix this

Hey, could you provide more info about your model and the query that you are trying to perform?

The model:

model GenericOrder {
    id           String   @id @db.VarChar(255)
    ....
    draft        Boolean  @default(false) @db.Boolean
    createdAt    DateTime @default(now()) @db.Timestamptz
    updatedAt    DateTime @updatedAt @db.Timestamptz
}

the query:

this.prisma.genericOrder.findMany({
	where: {
        AND: [
			{
				draft:
					typeof draft !== 'undefined'
						? {
								equals: draft
						  }
						: undefined
			},
			{
				createdAt:
					typeof dateFrom !== 'undefined'
						? {
								gte: new Date(dateFrom)
						  }
						: undefined
			},
			{
				createdAt:
					typeof newDateTo !== 'undefined'
						? {
								lte: newDateTo
						  }
						: undefined
			}
		]
    },
	orderBy: orderByFilter,
	take: Number(take),
	skip: (Number(page) - 1) * Number(take)
})

My question is, do you need to check if draft was passed inside of the query? Just brainstorming here

Wdym? Do you mean the check for if undefined or not?

I think this is because you’re strictly checking for the type of undefined and I’m not sure if in JavaScript false has type undefined. so the first filter Andra is never getting applied and only the last two might be. So you’re getting everything as a result

You can simply do:

draft: !!draft

This will do two things: • if draft is exists, pass true • If draft is 0, null, undefined, ‘’, false: then pass false But since for you type of draft is always Boolean or undefined, this simple line will do

@Samrith Shankar hi thanks for the reply, I already tried that one before but it doesnt work unfortunatly

What error does it give? Coz what you’re doing seems extremely unnecessary. What’s the value you get for

draft?

oh wait, you meant skipping to check for undefined, will trry that

Yeah!

oke, so the thing is,

draft

is optional right. it can come in as

undefined

. if I only do that you suggested, it sees the filter as

false

so only fetching records where draft is set to

false

. but if the filter is not on i need records where draft is both

true

and

false

Gotcha. In that case, could you try using a function like so?

function boolOrUndef(value) {
    if(typeof value === "boolean") {
        return value;
    }
}

// Usage:
where: { 
  draft: boolOrUndef(filters.draft)
}

cool, that works thanks! but isnt it the same as not using a function? I mean,

draft

is either a

boolean

or

undefined

, why does having a function for that work 🤔

To be honest, I can't really answer your question without having a look at your entire code (prisma.model.findMany....)

wait, i'll send it in a pastebin, if I implement it in my whole query it doesnt work. probably something off with my query then

Can you also log what the generated

where

is?

oke, this was my fault! it works as expected but I did something stupid haha. here

hasObjectValues

in the function I check if any of the filters has a value, if not then dont need to apply the

where

. but since

draft

can have a value of

false

it sees that as an incorrect value thus not accepting it...

I thought so 😄 Sometimes it is just the little things. I'm glad your issue got sorted!