It looks like the same kind of issue described her...
# prisma-clientc
Chris
09/07/2021, 7:25 PMIt looks like the same kind of issue described here https://githubmemory.com/repo/prisma/prisma/issues/7395
r
Ryan
09/08/2021, 5:29 AM@Chris 👋
Thanks for reporting. This is a known issue regarding both the Decimal and BigInt types and we will look into this 🙂
c
Chris
09/08/2021, 8:17 AMHi Ryan, thanks for getting back to me. I'm very new to Prisma so was initially thinking I was doing something wrong. After seeing that other issue it became clear to me it was actually a bug - so I opened an issue specific to Decimal here https://github.com/prisma/prisma/issues/9163
Chris
09/08/2021, 8:21 AM@Ryan I see the BigInt issue has been open for 3 months. As I say I'm very new to Prisma, so don't know how quickly one can expect fixes to issues. I'm very concerned about this issue - I'd say half of our queries will be executed via queryRaw - and already see this as a potential show stopper. Do you have a) a gut guess on how long it may take for a fix to appear, and b) any suggestions for a workaround in the meantime?
r
Ryan
09/08/2021, 2:56 PMUnfortunately we don’t have an ETA on this as we have other requests/bugs lined up. As for the implementation, this requires fixes in both the Engine and the TypeScri[t side - so it would take some time 🙂
c
Chris
09/09/2021, 10:06 AM@Ryan thanks for your response. We are developing a data reporting application, with TypeScript, with ~1/2 of the queries we need being hand written to perform calculations on Decimals. What library would you most recommend for such a use case? Do you think Prisma is still a good option?
Chris
09/09/2021, 10:06 AMAs a possible work around - do you think casting Decimals to Strings in our raw queries, and then parsing to Decimal.js objects code-side, would be a good option?
r
Ryan
09/09/2021, 11:55 AMYes I think that would be the only way as of now.
c
Chris
09/09/2021, 12:05 PM@Ryan do you think Prisma is appropriate for a use case like ours, where we have a lot of custom queries performing calculations?
r
Ryan
09/09/2021, 12:18 PMImo if you have a lot of custom/raw queries, then you would need to use Prisma’s raw query mechanism and pass the types for the data manually, so you won’t be getting the benefits of using Prisma in that case.
c
Chris
09/09/2021, 12:24 PMI like what Prisma offers in terms of:
• constructing the schema in code
• migrations
• convenient, typed results for 1/2 our queries
Chris
09/09/2021, 12:26 PMTo not have the benefits of typed queries on half our queries seems like it would be an acceptable trade-off, unless it presented significant obstacles for executing those queries.
r
Ryan
09/09/2021, 12:27 PMI don’t think it will be an obstacle as the raw query would just be untyped, there’s no other drawback.
c
Chris
09/09/2021, 12:28 PMIf the only obstacle is needing to cast to string in our query, and then create a decimal.js object with the result that comes back - and this is something that will eventually be fixed in Prisma - then I feel like it falls on the side of being acceptable
💯 1
Chris
09/09/2021, 12:28 PMI'm still new to Prisma though
r
Ryan
09/09/2021, 12:31 PMI’m still new to Prisma thoughThat wouldn’t be a problem, Prisma’s API is self explanatory if you’re running queries directly through Prisma and raw queries would be as is, so you should be fine 🙂
c
Chris
09/09/2021, 12:33 PMI wonder if middelware could be used to take care of this in the meantime ...
r
Ryan
09/09/2021, 12:39 PMIt should be, but you would need to recursively find all the fields in the response and convert them, so basically write the helpers yourself.
2 Views