https://www.prisma.io/ logo
Join Slack
Powered by
<@U0RQY0KK5> Should we expect a fix on the pokedex...
# prisma-whats-new
d
@nilan Should we expect a fix on the pokedex-react-native-vanilla repo? https://github.com/learnapollo/pokedex-react-native-vanilla/issues/2
n
@dk0r, just saw your comment: https://github.com/learnapollo/pokedex-react-native-vanilla/issues/2#issuecomment-308812183 I'm happy to review a PR for this issue 🙂 Note that the first one doesn't need to be considered in a PR
d
Understood, I put it there for noobs like me (who are the most likely audience of an introductory tutorial)
What about issue #3?
n
I don't see an issue #3
d
oh, sorry --I meant bullet #3
n
ah, you mean the deprecation warning
d
I'm not certain what dependency os.tmpDir() depends on
n
I think we can disregard that for now 🙂
d
in fact, right now, I'm toying around with the package.json to see what packages I can upgrade to the latest without breaking stuff
n
ah interesting
d
any reason not to update to latest stable react and react-native?
n
not that I know of
@dk0r what's your node version?
d
Okay. I'll try and do the tutorial with the latest version of the deps so make sure nothing is broke
👍 1
@nilan node 8.1.0
I'
n
I don't know where 
os.tmpDir
is used though, probably some package
d
I did a search for 
os.tmpDir()
in the entire project and found a lot of node packages using it
n
I think that's fine
d
okay --I haven't done a PR before though I get the basic idea. Any tips/conventions I should know about?
n
one that comes to mind is to focus on one thing in one PR and not introduce multiple different changes
d
Okay --so keep it simple and easy to diff
n
yea I mean a PR can easily span dozens of files, but mixing a fix for the issue you posted with say a new feature or so would be hard to review
I think we'll manage 😄
In this case it would be important to fix all folders, but luckily you said that only one 
solution
folder is problematic with the commit I sent you
d
yeah. Updating deps would requires vistis to multiple package.json's tho
n
arg
d
no problem tho'
I'll figure out what deps work and do a PR. Incurred first error pushing react-native from 
0.37
=> 
0.38
and react from 
15.3.1
=> 
15.4.0-rc.4

http://i.imgur.com/MuQkWZr.png▾

I'll keep messing w/ it
n
oh
is there a reason you're not upgrading RN to 
0.44
, and React to 
15.6.1
?
d
there was a peer depenedency asking for .38
and another peer asking for rc.4
n
hmm
d
will definitely try latest stables tho
n
I think it makes more sense to start with the RN/React version
d
oh, okay. I assumed I should try and satisfy peer dependency requests first and then move from there
will try latest stable now
n
nah, those packages are likely a bit dated as well
d
you mean the peer pkgs?
yeah good point
n
but I think the versions are only secondary, getting the repo in a working state with older versions would be a great improvement already
d
if it's asking for old versions, it's probably old itself
n
exactly
you would need a lot of iterations to "climb up" 😄
d
well, i have it working atm. Would just like to get the repo current as well if possible
n
gotcha, might as well take the opportunity 👍
d
I plan to use the example as a base (modified with react-navigation router for react native)
btw, any reason for rn 0.44 as opposed to .45.1?
n
that was the latest version I could find
where did you find more information? haha
d
npm view react-native versions --json
havent' found a yarn equivalent for that ^ 😕
n
haha cool didn't know that one
d
the --json is needed to expand lists that were compressed
n
Still for versions I like to consult official documentation.
d
hmm react-native 0.44.x depends on react 16 alpha's
how do you mean consult? For example, researching release notes to see whether subversions are relevant?
n
Yea exactly
d
k
n
but I found 
0.45
here 🙂 all good!
d
yeah, I would expect the site to be up to date w/ the node repo
hmm, not making a whole lot of progress
But there seems to be a significant diff b/w these two graph.cool react-native package.jsons:
learnapollo/pokedex-react-native: https://git.io/vHNh5
graphcool-examples/react-native-graphql: https://git.io/vHNhx
n
the latter was created with 
create-react-native-app
, the former hasn't 🙂 but those are both expo apps
d
@nilan I don't think that's correct. The latter (https://git.io/vHNhx) is vanilla react-native. There's no expo involved --it even includes 
android
and 
ios
dirs
@nilan, did you see that ^?
Also, I now have vanilla learnapollo running on react@16.0.0-alpha.12 but there are two issues I need further advice on.
n
Oh, you're right about the expo/vanilla thing. Sorry!
I'd rather use the latest stable version than an alpha version. Why did you choose this one?
d
Just tried pushing as far as I could go --I have Learnapollo running on stable react@15.6.1 as well
n
I think it's better to use this instead 🙂
d
now that you mention it, I think the two issues I wanted advice on are probably related to alpha breakage
n
let's hope so 😄
d
okay, give me a bit to clean up the 15.6.1 fork. Btw, what's the diff between the learnApollo and graphql-examples ?
graphql examples are built on react@16.0.0-alpha.6
n
what do you mean with graphql examples?
d
sorry, meant graphcool
graphcool-examples/react-native-graphql: https://git.io/vHNhx
versus
learnapollo/pokedex-react-native: https://git.io/vHNh5
Since the graphcool-examples are running react@16...-alpha, why not push learnApollo to the same?
n
Well, it's just two different repos 🙂 one difference is that LA is "slower moving" because it's just much bigger. I'd actually also prefer version 15.6 for 
react-native-graphql
as well 😉
d
One thing I found curious was that LA is using 
jest-react-native
whereas GCE doesn't include it at all
But yet both of them are using jest && babel-jest though 🤔 ...?
Also, my PR will only be 50% as I'm not setup to test OSX atm 😕
👍 1
btw, the reason for pushing to the react alpha is because the latest stable react-native@0.45.1 requires react@16.0.0-alpha.12
Open in Slack
PreviousNext
Powered by