Title
w
wesbos
10/27/2017, 4:10 PMwhat happened to this? https://github.com/graphcool/modules
a
agartha
10/27/2017, 4:10 PMIt went to https://github.com/graphcool/templates
w
wesbos
10/27/2017, 4:11 PMOhhh okay
is there nothing for Auth0?
s
sebastien
10/27/2017, 4:12 PMHere’s the PR: https://github.com/graphcool/templates/pull/112
👍🏻 1
w
wesbos
10/27/2017, 4:12 PMsweet thanks @sebastien
😎 1
Any ETA for a merge? I’d love to use it now 🙂
a
agartha
10/27/2017, 4:15 PMWell, it's usable as it is, just not fully reviewed yet 😄
w
wesbos
10/27/2017, 4:15 PMah I can just copy/paste it in
a
agartha
10/27/2017, 4:16 PMOr add it from the original repo
graphcool add-template fdidron/templates/auth/auth0w
wesbos
10/27/2017, 4:16 PMah perf!
a
agartha
10/27/2017, 4:17 PMJust tested that, and it works:
https://snag.gy/z73OiH.jpg▾
w
wesbos
10/27/2017, 4:22 PMtrying now - taking a long time
been ~5 mins
a
agartha
10/27/2017, 4:22 PMIt literally took <5 seconds for me
w
wesbos
10/27/2017, 4:22 PMill kill it and try again
that worked!
thank you again
👍🏻 1
a
agartha
10/27/2017, 4:23 PMDisclaimer: this is about authentication, and it's from a WIP PR, so please read the code yourself, and make sure you understand what happens, before going live!
m
markmiller21
10/27/2017, 11:38 PMhow long is the PR process typically in the graphcool repo? Basically, is this worth waiting for or go off the PR’d template
a
agartha
10/27/2017, 11:39 PMThat really depends. I have another review planned somewhere this weekend, I hope @nilan can have a look next week.
👍 1
m
markmiller21
10/27/2017, 11:55 PMporting over a firebase app. It;s definitely a priority but not so pressing that it is worth going with a shaky solution
a
agartha
10/27/2017, 11:56 PMWell, the solution is not shaky. I have already done a quick review, and I doubt that much will change.
n
nilan
10/29/2017, 2:33 AM@markmiller21 any specific reason you think that solution is shaky? looks good to me & will give it a final review early next week
m
markmiller21
10/29/2017, 10:17 PM@nilan No, not in particular. I am learning about graphDB and don’t have any experience with it so I did not want to learn a bad practice for auth if it could be avoided. But as far as I could tell, it looked great