This message was deleted.
# opal
s
This message was deleted.
o
Hi @loan75. Yes of course we test OPAL before releasing a version, but we do admit there's much room to improve that current test suite that we have. We'd love your (and anyone elses) help with it. Would you be willing to write some tests? 🙏 Not sure what you mean by very hidden documentation: it's hosted and navigable at docs.opal.ac OPAL_DATA_CONFIG_SOURCES is not optional,
l
OPAL_DATA_CONFIG_SOURCES is not optional but it can be empty. All policies do not need to rely on data.
(also, some data can be loaded directly from the policies)
o
Yeah, I agree that there's a regression here, though we (and most users of OPAL) always load some data as well, so I guess @Ori Shavit and @Asaf Cohen overlooked the scenario. We can look at providing a fix here, perhaps in the interim as a stop gap solution, load some dummy data?
l
well i am hosting like 5 OPAL cluster. I agree that all have data except one than only rely on static data that are imported by the policies.
🤘 1
well i put a dummy configSources as a work around for now.
dataConfigSources: config: entries: [ { "url": "", "topics": ["policy_data"], "data": {}, "dst_path": "/dummy" } ]
o
Quite literal :)
p
FWIW, I also got confused by this when I was deploying OPAL from the helm chart the first time (had to set flags
OPAL_DATA_UPDATER_ENABLED=0
and
OPAL_OPA_HEALTH_CHECK_POLICY_ENABLED=1
in order to get a healthy deployment) https://github.com/permitio/opal-helm-chart/issues/23 Could perhaps be a nice thing to mention in an helm chart FAQ or similar? I guess it's not too uncommon to not have any external data sources at hand the first time you try to deploy OPAL.
r
quick update regarding those issues around the health check: https://github.com/permitio/opal-helm-chart/issues/31#issuecomment-1476554198
👍 2
Closed the issue: https://github.com/permitio/opal-helm-chart/issues/31#issuecomment-1486399982 Bottom lines: 1. You don’t have to set
OPAL_OPA_HEALTH_CHECK_POLICY_ENABLED: True
for opal-client’s http health check to work. 2. When client is not expected to load any data (
OPAL_DATA_CONFIG_SOURCES
is empty, no json files in git repo) - you should set
OPAL_DATA_UPDATER_ENABLED: False
for client to report healthy state. 3. OPAL’s monitoring tutorial & OPAL’s helm chart README were updated with this information.