This message was deleted.
# opal
s
This message was deleted.
o
Hi @Philip Claesson! Quite a mystery. Can you share the logs for the server and the client ? Might have clues to debug. Also summoning ๐Ÿช„ @Asaf Cohen and @Shaul Kremer for insight
a
Hi @Philip Claesson ๐Ÿ™‚ Could you please add your full docker compose / way you launch opal? Also please attach the full logs so we can investigate.
p
Hey again! We're deploying using the latest version of the opal-helm-chart. When properly investigating the env variables I think I may have figured it out. I noticed that my opal-client deployment has the data updater set twice:
Copy code
OPAL_DATA_UPDATER_ENABLED:             true
OPAL_DATA_UPDATER_ENABLED:             false
I think the
true
comes from our values.yaml, the false one comes from this line. As we don't specify data sources through values.yaml but instead through envFrom from a secret (since it contains db credentials).
o
Cool. ๐Ÿ˜‡ So just to verify - the problem is solved?
p
Not really - we need to modify the helm chart. Currently it makes assumptions about what is sent in via values.yaml while some things may actually be overridden via env variables from secrets. I'll draft a PR ๐Ÿ™‚
o
Roger that - Thought youโ€™d just switch to / propagate into the values.yaml. @Raz Co can you keep an eye on @Philip Claessonโ€™s PR as it is coming in
r
Hey @Philip Claesson, I see your fresh new PR - Iโ€™m taking a look ๐Ÿ™‚
๐Ÿ™Œ 1
p
Thanks @Raz Co! There are a bunch of different ways this could be solved I think, this is what I came up with. Hopefully the description helps explain it. https://github.com/permitio/opal-helm-chart/pull/51/ Basically, we need to support passing data source config via secret rather than via the helm chart (since the config may contain secret connection params).
I'm happy to discuss other ways of solving it if you have other ideas ๐Ÿ™‚
r
Totally understand the need here. Iโ€™m planning to make a much smarter way to deal with these variables in the next major OPAL release.
๐Ÿ™Œ 1
p
Thanks for merging @Raz Co! That sounds really good. It just struck me, perhaps it ended up being a bit weird. Now we're looking for the env variable OPAL_DATA_UPDATER_ENABLED on the server config, and if it does not exist we set it on the client.
Not a breaking issue but a bit illogical imo, I suggest we change it: https://github.com/permitio/opal-helm-chart/pull/52
r
Nice catch ! Thanks, I merged this ๐Ÿ™‚
๐Ÿ™Œ 1