Permit

Hi <@U04KNLJQ9Q9> ,
Just had a similar conversation with <@U0542CQ7B2B> a few weeks ago
<https://permit-io.slack.com/archives/C01RUUYV3TP/p1684741048923209>

the file name needs to match `.*data.json`

Okay, so if I have subscription-data.json it'll load it. But what happens when I load it, is that none of the other data that OPAL loads in fetchers populates.

If I remove the file from git. The fetchers work again.

I’m guessing the data path trees overlap and override one another

Is it possible my data json formatting is causing some issue?

Let me look at the code quickly - I’m not sure how the merge flow works here (<@U033FPT0BFH> wrote that part :stuck_out_tongue: )

The folder path the `.*data.json` is under is used as the path in OPA (Can’t say I’m a fan)
<https://github.com/permitio/opal/blob/a5ec96a11196957ee5b89d35352ec55a50b39f55/opal/common/git/bundle_maker.py#L36>

and if it’s in the root folder that means it would override anything in the root

In general we support `data.json`  only as a backward compatibility to vanilla OPA.

But I guess we can improve this - there should be a better way to indicate the path that data.json should go within OPA
<@U033FPT0BFH> / <@U02CN8CVBJL> for your cosideration

For now <@U04KNLJQ9Q9>, you can just put the file under a folder

So if it's in a folder in the repo what will it resolve to in the directory? Like... /v1/data/foldername?

Yes (If I read the code correctly :sweat_smile:)

And all *data.json files will merge together into one under that directory.

I think you should have only one per folder :sweat_smile: - or they’ll end up overriding one another

:joy: Yeah that's... That's maybe not ideal behavior.

I can deal with it. It doesn't stop me. Just needs some really explicit documentation at least.

I agree, that code hasn’t changed since <@U033FPT0BFH> and I first wrote OPAL in my living room (over 2 years ago)

I’m testing this right now. Moved my data file under a folder. Waiting for OPAL to pick it up.

Hey that worked. I moved `subscriptions.json` to `subscriptions/data.json` and it picked up under the path `/v1/data/subscriptions` :raised_hands::skin-tone-2:

Yey! :partyparrot:
I always believed :stuck_out_tongue:

<https://github.com/permitio/opal/pull/474>
<@U03RJ7ZB18Q> when you can please review / approve

I reviewed and approve. I think this will direct people the right way. Although, I am now curious about the tenant mechanism where you have multiple opal clients with different tenants. Does this mean all tenants load all static data.json? Or is it just because I left that env default that it grabbed everything.

I don't see the approve button on github mobile. Or I don't have rights to approve.