This message was deleted.
# opals
Slackbot
05/25/2023, 10:52 AMThis message was deleted.
o
Or Weis
05/25/2023, 10:57 AMHi @Charlie Batten - welcome 🙂
I’m planning on answering you here, I’m just in a few meetings at the moment - will reply soon
c
Charlie Batten
05/25/2023, 10:57 AMThank you so much - there's no rush at all!
o
Or Weis
05/25/2023, 11:07 AMAnswered on Github, but adding here as well 🙂
You can use the
OPAL_POLICY_BUNDLE_SERVER_TOKENOr Weis
05/25/2023, 11:10 AMIf you need a more advanced authentication scheme, it would require code changes, here: https://github.com/permitio/opal/blob/f1a9c318554c81e2b030e8df74059924cd0400c7/packages/opal-common/opal_common/sources/api_policy_source.py#L116
PRs are welcome, and we can also add it to the roadmap
c
Charlie Batten
05/25/2023, 11:16 AMYes, unfortunately, I don't believe I have a way to generate a bearer token for use in that env var. If it does help, our previous deployment was using OPA (without OPAL) with the following arguments:
Copy code
@echo off
SET AWS_ACCESS_KEY_ID=REDACTED
SET AWS_SECRET_ACCESS_KEY=REDACTED
SET AWS_REGION=uk
opa_windows_amd64.exe run -s -l debug --set "services.s3.url=<http://s3-local>" --set "services.s3.credentials.s3_signing.environment_credentials=null" --set "bundles.authz.service=s3" --set "bundles.authz.resource=open-policy-agent-bundles/env/bundle.tar.gz"Charlie Batten
05/25/2023, 11:16 AMWe've only got those two AWS keys to use as auth
o
Or Weis
05/25/2023, 11:18 AMI’m afraid not, as it is not OPA talking to the bundle-server but the OPAL-server.
This is a missing feature - would you be willing to try and do a PR for it?
Otherwise I can check if @Asaf Cohen / @Ro'e Katz / @Ori Shavit can get to it next week
c
Charlie Batten
05/25/2023, 11:21 AMI'm afraid that python is far from my specialty and I'm kind of muddling my way around as is 😕
o
Or Weis
05/25/2023, 11:24 AMGot it, and can it wait for early next week?
c
Charlie Batten
05/25/2023, 11:24 AMYes of course! That would be brilliant 😄
o
Or Weis
05/25/2023, 11:24 AMCool. I’ll get the team on it 😇
c
Charlie Batten
05/25/2023, 11:25 AMThank you so so so much
Charlie Batten
05/25/2023, 11:25 AM😄
o
Or Weis
05/30/2023, 2:10 PMHi Charlie - lacking free team members to work on this I ended up doing it myself
https://github.com/permitio/opal/pull/472
Can you give it a try before we merge it to master ?
c
Charlie Batten
05/31/2023, 6:49 AMHi Or, I gave it a quick go yesterday, but was unsuccessful in making the request. I'll have a play with it today and see if I can get it working 🙂
👍 1
Charlie Batten
05/31/2023, 8:01 AMI've made some code changes, and have successfully got the bundle downloading!
Charlie Batten
05/31/2023, 8:01 AMAre you happy for me to push them to the branch you created, or would you rather I make a new branch for it?
o
Or Weis
05/31/2023, 8:09 AMThat's awesome! Teamwork 💪
A new branch and pull request would be better for the CR flow
c
Charlie Batten
05/31/2023, 8:46 AMI'm trying to push the branch, and am getting this error:
Copy code
remote: Permission to permitio/opal.git denied to cbat98.fatal: unable to access '<https://github.com/permitio/opal.git/>': The requested URL returned error: 403a
Asaf Cohen
05/31/2023, 9:04 AMHi @Charlie Batten in order to contribute you need to fork the OPAL repo and then open a pull request from a branch on your fork repo to @Or Weis’s branch on the main OPAL repo
Asaf Cohen
05/31/2023, 9:05 AMOnly the core maintainers can open pulls directly on the main OPAL repo
c
Charlie Batten
05/31/2023, 9:05 AMI see, thanks Asaf. I'll get on that 🙂
🚀 1
Charlie Batten
05/31/2023, 9:05 AMThis is my first time PRing OSS 🙂
a
Asaf Cohen
05/31/2023, 9:06 AMReally exciting @Charlie Batten !! We are honored your first contribution is to OPAL 🙂
c
Charlie Batten
05/31/2023, 9:57 AMPR is up 🙂
Charlie Batten
05/31/2023, 9:57 AMLet me know if there are any more details needed
💜 1
o
Or Weis
05/31/2023, 10:05 AMWill review shortly.
Or Weis
05/31/2023, 11:51 AMHi @Charlie Batten looks great - requested a tiny change in the review - fix it and we’d be good to go
👍 1
Or Weis
05/31/2023, 11:52 AM@Daniel Bass please be in touch with @Charlie Batten to send him some SWAG in gratitude to his contribution to the project 🙂
❤️ 1
👍 1
d
Daniel Bass
05/31/2023, 12:08 PM@Charlie Batten Sending you a DM 🙂
c
Charlie Batten
05/31/2023, 12:55 PMDo you have a release cycle for releasing versions of the docker images to docker hub?
o
Or Weis
05/31/2023, 12:58 PM@Ro'e Katz is aiming for a release next week.
In general - on avg. we do once a month.
c
Charlie Batten
05/31/2023, 12:58 PMOk thank you 😄
💜 1