Hi, team! Just realized that pact_verifier_cli exits with status 0 even if the pact verification fails. This makes it difficult to configure the CI/CD pipeline. Could someone advise if there is a way around this without resorting grep output?

Hey, This would best be raised in pact-rust as it is built on from the pact-reference (rust-core) repo. It should exit with 0 checking on previous issues https://github.com/pact-foundation/pact-reference/issues/47 would you be able to create a reproducible issue on there please

I deployed a new broker from scratch, no pact in it yet. Then I published the first contract in it and made the very first verification attempt (it failed). And it still ended with a status code of 0. So I don’t think it has anything to do with whether it’s a new issue or not.

Please don't tag maintainers directly, as stated you can raise an issue in the respective repo please

I’m sorry, Ok

It sounds like a regression based on the previous issue which was raised (sounds similar to yours) and was fixed as a bug, so raising an issue, with your exact scenario would help the maintainers and contributors offer support 👍

Let me check

actually sorry, that piece of code I showed earlier will exit if it fails to write the errors to a file (json or junit) this portion https://github.com/pact-foundation/pact-reference/blob/f63b7b66cc5d275f6331eeccf9f05f2a4de6359d/rust/pact_verifier_cli/src/main.rs#LL391-L393C8 this maps an error

.map_err(|err| {
      error!("Verification failed with error: {}", err);
      2
    })

not sure if that is used on 410, or it just exists with exit code 1 on a failure

Unfortunately, the two previous versions are subject to this issue.

I've just said I will upgrade now and try, can you show us the exact commands you are using and your failing output, and successful exit code

ty!

Yeah

you've not verified that consumer pact, on the feature branch and therefore the verifications wont fail your verification task

Just got it

that is by design

all the magic in

--enable-pending

if your provider was incompatible with the deployed consumer it would fail with an exit code of 0

Thank you so much for helping me understand

It's ok chap! Appreciate you wanting to get involved and contribute, but it's just difficult when people get tagged (some people are in different timezones as well). That was a really good bug report on GitHub so thank you for that. The art of asking a good question, is a skill that takes a lifetime to hone. TY for your Python efforts too (we would like to increase maintainer / contributor capacity there so your eyes/PR's are appreciated, even if we don't get to them straight away!)

Glad you sorted it out. For a moment there I thought I was going to get shouted at for breaking something.

Again, I apologize for my conduct

not at all!