So I have definitely entered the matrix.
1. Wante...
# pact-js-developmenty
Yousaf Nabi (pactflow.io)
03/15/2022, 1:57 AM
So I have definitely entered the matrix.
1. Wanted to add a PR here to pact-js but the builds were failing as identified here
2. The root cause, we believe was raised in this issue here in pact_broker-client and merged here by Beth and released as v1.59.0
3. This triggers a pact standalone upgrade to v1.88.83
4. This then triggers an update to pact-js-core here which was merged and released as v13.5.1 and published to npm as pact-core
a. there is a seperate issue with windows builds here failing, raised here
5. Went to update pact-js, and it depends on pact-node npm package which is on v10.17.1 updated 3 months ago.
Now then, what has started off as something simple has ended up being a bit larger.
• The GH repo github.com/pact-foundation/pact-node has been renamed to https://github.com/pact-foundation/pact-js-core
• There are 2 npm packages https://www.npmjs.com/package/@pact-foundation/pact-node and https://www.npmjs.com/package/@pact-foundation/pact-core
• pact-js
masterpact-nodepact-corev3😭 2
😆 1
m
Matt (pactflow.io / pact-js / pact-go)
03/15/2022, 2:19 AM
TL;DR - the mainline version of Pact JS uses the
pact-nodepact-js-coreMatt (pactflow.io / pact-js / pact-go)
03/15/2022, 2:19 AM
it needs to be manually released - i’ll do that now
Matt (pactflow.io / pact-js / pact-go)
03/15/2022, 2:19 AM
Pact JS v3 uses the new module name, yes
Matt (pactflow.io / pact-js / pact-go)
03/15/2022, 2:20 AM
I’ll brief you on the status of that in the coming days, but it’s back on track now that we have a C++ / node-gyp layer that provides a native interface to Rust
🤘 1
😍 1
Matt (pactflow.io / pact-js / pact-go)
03/15/2022, 2:25 AM
Releasing latest pact-node now…
👌 1
Matt (pactflow.io / pact-js / pact-go)
03/17/2022, 9:37 AM
FYI regarding https://github.com/node-ffi-napi/ref-napi/pull/64#issuecomment-1067493234, we have moved on now and are unblocked as far as the v3 migration is concerned. I don’t see us going back to ref-napi any time soon. There are fatal flaws in the design (that were exposed via this issue) that a small PR won’t fix.
Whilst the C++ code looks complex, the reality is once we have a stable integration up and going, it could probably be automated by a conversion script that reads the c++ headers and converts into the boilerplate code.