Hey folks! I've been sort of just dipping my toe i...
# pact-pythonj
json
03/07/2022, 3:26 PMHey folks! I've been sort of just dipping my toe into the pact-python examples and was wondering why the pact fixture is registering stop_service with atexit and using a fixture to call stop_service after the test session is done? Isn't this redundant?
m
Mike Geeves
03/07/2022, 4:13 PMimo you want to have the atexit to handle if you kill it uncleanly, to avoid the port being left open
if you only have the atexit then the clean handling of stopping the service and pushing to the broker won't happen because it's too late, at the exit
Mike Geeves
03/07/2022, 4:14 PMpretty sure I verified Bad Things happened with only atexit but let me know if that's not the case 🙂
j
json
03/07/2022, 4:15 PMI thought I read that atexit doesn't work if you kill the program
json
03/07/2022, 4:17 PMThe functions registered via this module are not called when the program is killed by a signal not handled by Python, when a Python fatal internal error is detected, or whenhttps://docs.python.org/3/library/atexit.htmlis called.os._exit()
m
Mike Geeves
03/07/2022, 4:17 PMfair enough with a kill -9
Mike Geeves
03/07/2022, 4:17 PMbut if you're having exceptions raised etc that stops the flow
j
json
03/07/2022, 4:18 PMI think pytest will always run the cleanup if there is an error in the test though, won't it? At least, by design
json
03/07/2022, 4:19 PMIt seems it doesn't if the error was within the fixture itself, but even then it'll still run the cleanup of any other fixture which it has finished setting up
m
Mike Geeves
03/07/2022, 4:20 PMperhaps try it 🙂
👍 1
Mike Geeves
03/07/2022, 4:20 PMexamples are in progress, so they've been cleaned up a bit but there are probably extra bits not needed that may have been preferred previously etc
Mike Geeves
03/07/2022, 4:21 PM*always in progress
🙂
j
json
03/07/2022, 4:21 PMOh sure. I'm fairly new to pytest fixtures anyways, so maybe I'm misunderstanding something. I actually learned about them just to understand the pact-python examples, ha
👍 1
m
Mike Geeves
03/07/2022, 4:22 PMalways more to learn for sure! 🙂
j
json
03/07/2022, 4:22 PMI like them a lot though, the design lends itself well to an inversion-of-control style of test setup
🙌 1
m
Mike Geeves
03/07/2022, 4:23 PMglad to hear that 🙂
Mike Geeves
03/07/2022, 4:24 PMthe approach of shared fixtures was new for me 🙂 it's a little hacky but works pretty nicely
j
json
03/07/2022, 4:26 PMYeah, I might actually make the scope of the Pact fixture "package" instead of "session" and namespace my tests based on provider so I am automatically creating a new pact for each provider which my consumer has pacts with. Yay dependency injection!
m
Mike Geeves
03/07/2022, 4:37 PM🤔 that would make sense I think, simple examples are always fine until you try to do the next step 😂
👍 1