ether fix my code or replace all undefined with nu...
# pact-jsa
Artur Neumann
03/07/2022, 7:07 AMether fix my code or replace all undefined with null? https://muffinman.io/blog/json-stringify-removes-undefined/#using-replacer-parameter
m
Matt (pactflow.io / pact-js / pact-go)
03/07/2022, 7:09 AM
I think I should update the Typescript type to prevent the use of undefined in the parameters - that’s the first step
Matt (pactflow.io / pact-js / pact-go)
03/07/2022, 7:09 AM
but it won’t fix JS users, so it will need some validation also
Matt (pactflow.io / pact-js / pact-go)
03/07/2022, 7:10 AM
I think we should explictly error if we find
undefined👍 1
Matt (pactflow.io / pact-js / pact-go)
03/07/2022, 7:11 AM
In your case, I’m not sure what works best - replacing
undefinednulla
Artur Neumann
03/07/2022, 7:12 AMI'm trying now
Copy code
optionalParams = JSON.stringify(optionalParams)
optionalParams = JSON.parse(optionalParams)Artur Neumann
03/07/2022, 7:12 AMthat should delete all keys with undefined values
💯 1
Artur Neumann
03/07/2022, 7:20 AMmessage has been deleted
Artur Neumann
03/07/2022, 7:23 AMTHX
m
Matt (pactflow.io / pact-js / pact-go)
03/07/2022, 7:41 AM
Excellent! Thanks for letting me know. I'll fix the above in the next release (next few days)
Matt (pactflow.io / pact-js / pact-go)
03/07/2022, 10:14 AM
I’ve made a patch locally for this. It’s not my ideal solution, but having it will prevent a regression and provide a target for addressing later.
Matt (pactflow.io / pact-js / pact-go)
03/07/2022, 10:14 AM
I’ll push it up in the next couple of days
2 Views