Hi folks, here's a set of PRs to add `arrayContain...
# general
s
Hi folks, here's a set of PRs to add
arrayContains
matcher to plugin matcher language and implement it in protobuf plugin. I don't have enough context to implement it in other plugins (nor have I a definite list of all available plugins), not sure what's the best way to handle such a change. https://github.com/pact-foundation/pact-reference/issues/523 - adds arrayContains to pact_models https://github.com/pactflow/pact-protobuf-plugin/issues/236 - implementation in protobuf plugin (draft since pact_models needs to be released first) https://github.com/pact-foundation/pact-plugins/issues/95 - grammar docs All PRs are done by AI of course, so please let me know if there are any issues 🙂
thankyou 1
r
I'll need to review it carefully. Or more likely, get an AI to review it.
thankyou 1
s
thanks! it's a big change, and because it's written by AI, there's a chance of hallucinations, but it did write some tests. fingers crossed.
Or more likely, get an AI to review it
this is the way 🙂
r
pact_models has been released, I'll get onto the next PR soon
s
awesome, thank you!
oops, my claude forgot this important fix to the pact_models, sorry (it had it locally but forgot to push): https://github.com/pact-foundation/pact-reference/pull/527
r
naughty claude
s
I told it to stand in the corner and think about its behavior
🤣 1
thanks for releasing updated models so quickly. I've updated the plugin PR to point to the live models crate now: https://github.com/pactflow/pact-protobuf-plugin/pull/236
Friendly ping on these 🙂 my claude also decided to go ahead and tag you on both PRs too, sorry
r
oh, sorry, been caught up with work stuff. It always seems to get in the way.
🙃 1
s
no worries, thanks for looking into this!
r
I'm getting a compile error on the Protobuf plugin PR. Issue updated with a comment
thankyou 1
s
claude handled it, hopefully he didn't mess up this time, sorry about that!
r
No worries. Copilot has gone walkabouts. I love how GitHub has an option to fix the merge conflicts, which just adds a comment for Copilot to fix the conflict, and Copilot does nothing.
🫠 1
s
we're turning into babysitters
☝️ 1
not that I mind, these savant kids can deliver massive code improvements in very little time.. but then stumble upon the easiest thing, get distracted by something unrelated and waste days hallucinating
😆 1