Hello, some of our provider cannot verify its contracts any more and return an emty list of pacts from http://broker.org/pacts/provider/ms.advice-conversation/for-verification

{
  "_embedded": {
    "pacts": []
  },
  "_links": {
    "self": {
      "href": "<http://broker.org/pacts/provider/ms.advice-conversation/for-verification>",
      "title": "Pacts to be verified"
    }
  }
}

Yet I do have contracts in

/pacts/provider/ms.advice-conversation/

. What am I missing here?

The pacts to verify depends on selectors. What selectors are you using?

i also got that sometimes

@Matt (pactflow.io / pact-js / pact-go) I didn't configure any selectors, where can I see that?

when you set up wich pact to test , you don't use a consumer selector ?

@Fábio Rodrigues Not at the moment

in jvm you should have something similar

We have this error in CI:

> Task :testContract FAILED
AdvisorsControllerContractVerificationTest > pactVerificationTestTemplate(PactVerificationContext) > com.manomano.ms.advice_conversation.application.controllers.AdvisorsControllerContractVerificationTest.initializationError FAILED
    au.com.dius.pact.provider.junitsupport.loader.NoPactsFoundException: No Pact files were found to verify
    Provider: ms.advice-conversation
    Source: Pact Broker <https://broker.org>
        at app//au.com.dius.pact.provider.junit5.PactVerificationInvocationContextProvider.provideTestTemplateInvocationContexts(PactJUnit5VerificationProvider.kt:50)

you should have a log entry (maybe you need to set the log level to debug) where you can see the post call to retrieve the contracts

Got

POST

with

"{"consumerVersionSelectors":[],"includePendingStatus":false}"

08:59:10.342 [Test worker] DEBUG org.apache.hc.client5.http.wire - http-outgoing-1 >> "POST /pacts/provider/ms.advice-conversation/for-verification HTTP/1.1[\r][\n]"
    08:59:10.345 [Test worker] DEBUG org.apache.hc.client5.http.wire - http-outgoing-1 >> "Content-Type: application/json; charset=UTF-8[\r][\n]"
    08:59:10.348 [Test worker] DEBUG org.apache.hc.client5.http.wire - http-outgoing-1 >> "Accept: application/hal+json, application/json[\r][\n]"
    08:59:10.349 [Test worker] DEBUG org.apache.hc.client5.http.wire - http-outgoing-1 >> "Accept-Encoding: gzip, x-gzip, deflate[\r][\n]"
    08:59:10.350 [Test worker] DEBUG org.apache.hc.client5.http.wire - http-outgoing-1 >> "Content-Length: 60[\r][\n]"
    08:59:10.351 [Test worker] DEBUG org.apache.hc.client5.http.wire - http-outgoing-1 >> "Host: <http://broker.org|broker.org> [\r][\n]"
    08:59:10.352 [Test worker] DEBUG org.apache.hc.client5.http.wire - http-outgoing-1 >> "Connection: keep-alive[\r][\n]"
    08:59:10.355 [Test worker] DEBUG org.apache.hc.client5.http.wire - http-outgoing-1 >> "User-Agent: Apache-HttpClient/5.1.3 (Java/11.0.16)[\r][\n]"
    08:59:10.356 [Test worker] DEBUG org.apache.hc.client5.http.wire - http-outgoing-1 >> "[\r][\n]"
    08:59:10.361 [Test worker] DEBUG org.apache.hc.client5.http.wire - http-outgoing-1 >> "{"consumerVersionSelectors":[],"includePendingStatus":false}"
    08:59:10.388 [Test worker] DEBUG org.apache.hc.client5.http.wire - http-outgoing-1 << "HTTP/1.1 200 OK[\r][\n]"
    08:59:10.388 [Test worker] DEBUG org.apache.hc.client5.http.wire - http-outgoing-1 << "Date: Wed, 31 Aug 2022 08:59:10 GMT[\r][\n]"
    08:59:10.388 [Test worker] DEBUG org.apache.hc.client5.http.wire - http-outgoing-1 << "Content-Type: application/hal+json;charset=utf-8[\r][\n]"
    08:59:10.388 [Test worker] DEBUG org.apache.hc.client5.http.wire - http-outgoing-1 << "Content-Length: 191[\r][\n]"
    08:59:10.388 [Test worker] DEBUG org.apache.hc.client5.http.wire - http-outgoing-1 << "Connection: keep-alive[\r][\n]"
    08:59:10.389 [Test worker] DEBUG org.apache.hc.client5.http.wire - http-outgoing-1 << "Vary: Accept[\r][\n]"
    08:59:10.389 [Test worker] DEBUG org.apache.hc.client5.http.wire - http-outgoing-1 << "X-Pact-Broker-Version: 2.102.1[\r][\n]"
    08:59:10.389 [Test worker] DEBUG org.apache.hc.client5.http.wire - http-outgoing-1 << "X-Content-Type-Options: nosniff[\r][\n]"
    08:59:10.389 [Test worker] DEBUG org.apache.hc.client5.http.wire - http-outgoing-1 << "[\r][\n]"
    08:59:10.389 [Test worker] DEBUG org.apache.hc.client5.http.wire - http-outgoing-1 << "{"_embedded":{"pacts":[]},"_links":{"self":{"href":"<http://broker.org> /pacts/provider/ms.advice-conversation/for-verification","title":"Pacts to be verified"}}}"

yeah, you're not using any selectors

With the following consumer selectors I'm able to fetch the contract. However, it's still unclear to me why I need to specify the selector on this provider but not the other? Why do I need to specify the branch? I see many verified contract version include

HEAD

as a value

@PactBrokerConsumerVersionSelectors
    public static SelectorBuilder consumerVersionSelectors() {
        return new SelectorBuilder()
            .branch("abmm-5295");  // why do I need to specify the branch?
    }

Maybe just send latest set to true and no branch,?

I'm able to fetch a contract when I specify the branch with which the contract is labelled (

abmm-5295

). However, I haven't specified any branch in most of our projets and we still are able to fetch and verify. Did a default behaviour regarding the contract fetching mechanism changes in the past few months? Or is it cheering luck that they passed? cc @Matt (pactflow.io / pact-js / pact-go)

@Édouard Lopez we could spend a lot of time trying to work out why it used to work and doesn’t now, but I think it would be better to spend that time adding in the branches and using them as recommended.

Thanks, we are publishing from the merge request pipeline so the contract are not tagged with the

mainBranch

, that's a mistake

If it’s from the merge request pipeline, then they should be included in the WIP pacts.

Yep, WIP show them ✌️