hi there, I noticed on the pactflow UI, the provid...
# pactflow
m
hi there, I noticed on the pactflow UI, the provider contract no longer shows the swagger docs, but rather is showing the verification document. is this intended? if so, where can I view the swagger file? thanks
image.png
m
Is it not showing a render of the OAS below? If so that would seem to be a bug
m
yep not showing anything, the page is blank and is just showing "Your provider contract is compatible with the provider codebase", then shows the verification file when clicked
I can raise a bug, is it under the pactflow roadmap?
m
Thanks. Creating a customer care ticket is the way to go, it will route straight to the dev team and then I can help prioritise it
✅ 1
👍 1
m
done - Case #00669310
thankyou 1
we seem to have an issue where a provider change wasn't failing the canIDeploy when it should (it was failing previously), when investigating we noticed we can't actually view the contract to compare manually on what pact is looking at, so may be related
🤔 1
m
What’s the name of the provider having issues?
m
testing is with trading-provider-integral, but the lack of rendering of the swagger UI is across the board
m
thanks, let me check a few things
m
it's a query string comparison, where the query string properties are matched on type, the provider had to specify the reqquest query as all strings as it was failing when a number was expected for one of the properties. For testing, the property was changed to a number again and it did not fail this time, even though the consumer has not changed (ie the request still has a query string with properties)
👍 1
no probs ta!
m
OK the OAS thing is a bug, I’ll have it prioritised ASAP - you can fall back to the old UI for this (which you know I hate to say of course!)
👍 1
as for the other thing (can i deploy), let me check something
👍 1
m
happy to wait for the new UI fix if it's unrelated to the second thing np
m
yeah I think it’s unrelated, the OAS is definitely in the system. I think with query strings, in BDCT they aren’t typed (all query strings are strings), this might be what you’re experiencing. Just testing something now
👍 1
m
yeah the expectation is provider pipeline to fail if one of the query props is changed to a num instead of a string
👍 1
m
OK I just checked and it should fail if the type changes - I recall query strings and parameters being a little messy (see https://github.com/pactflow/bdct-oas-examples/tree/main/examples/parameters) and https://docs.pactflow.io/docs/bi-directional-contract-testing/contracts/oas/features.
FYI the UI should be fixed now
🙌 1
m
hm, so regarding the parameters, there are no warnings shown on consumer side regarding the query parameter in question. in a previous situation, the consumer's can-i-deploy fails when comparing to a provider contract where the parameter was defined as a number and not a string (because consumer has all strings), but the reverse isn't true. i.e. the provider can-i-deploy doesn't fail when it's defined as a number and not a string (again, consumer has it as all strings)
if it works this way then potentially providers can introduce a breaking change that will blocks consumers but not itself