Hazem Borham
08/16/2022, 7:24 PMHazem Borham
08/16/2022, 7:24 PMcontract_requiring_verification_published
• Webhook 2 - Update Consumer's PR build status for the commit with the verification results using event provider verification published
Another sequence diagram documented here.
This all works great! However, the intent of webhook 2 is really meant for consumer PR builds and I noticed an undesired side-effect. In the case of Provider CI's, a provider feature branch failed verification due to a breaking change on the provider branch. This was great and awesome it was detected on the provider CI and PR.
However, webhook 2 fired as a result of the published verification from the provider feature branch against the consumer main branch. Ultimately this updated consumer's main branch commit with a failed build status and alerted the consuming team via their own slack notification. Ultimately we decided it was a false alarm.
Do others experience the same? Considering webhook 2 is meant purely for consumer's CI, it would be nice for webhooks to have conditions.