Has anyone seen any issues upgrading from v9 to v1...
# pact-jsa
Adam Witko
08/11/2022, 2:26 PMHas anyone seen any issues upgrading from v9 to v10, and the TS type changes for customProviderHeaders for the Verifier requires it to now be
customProviderHeaders: { [key: string]: string }Adam Witko
08/11/2022, 2:28 PMThe v9 to v10 also states there are no changes but I think this shows there are a couple (providerVersionBranch -> providerBranch is another)
Adam Witko
08/11/2022, 2:33 PM@pact-foundation/pact@10.0.2@pact-foundation/pact-core@13.7.1t
Timothy Jones
08/11/2022, 2:35 PMFirst one is a bug, I think. Can you open an issue on https://github.com/pact-foundation/pact-js-core please
Timothy Jones
08/11/2022, 2:36 PMSecond one, it looks like those options were independently added to pact-node and pact-js-core, so it would have been missed when the migration guide was written. I’ll make a PR that updates this.
👍 1
Timothy Jones
08/11/2022, 2:38 PMFirst one is an easy fix, I think. I don’t think it ever would have worked
a
Adam Witko
08/11/2022, 2:41 PMSure, will open a bug there. And I get ya about the migration comments, thanks 🙂
Adam Witko
08/11/2022, 3:02 PMAlready on it, what a gent @Timothy Jones clap all !
t
Timothy Jones
08/11/2022, 3:05 PMIt was more fun to fix the bug first 😉
Timothy Jones
08/11/2022, 3:05 PMI’m afraid I’m not a maintainer any more so you’ll have to wait for someone to merge it
Timothy Jones
08/11/2022, 3:09 PMa
Adam Witko
08/11/2022, 3:17 PMI can wait a smidge, this was spotted as I was working on some of internal packages using v9 and moved to v10 of pact-js and spotted it. No one is crying for this fix from us other than myself so we can use v10 goodness 🙂
❤️ 1
3 Views