https://pact.io logo
Join Slack
Powered by
<@UELMFD9PG> when you’re up, do you know why prebu...
# pact-js
m
@Yousaf Nabi (pactflow.io) when you’re up, do you know why prebuildify is trying to download node v 22 headers https://github.com/pact-foundation/pact-js-core/actions/runs/8796186333/job/24138602290#step:5:47
blobwave 1
You can see here, that prebuildify is setting it to 22 for some reason: https://github.com/pact-foundation/pact-js-core/actions/runs/8797074139/job/24141198473#step:5:211
In any case, I don’t know why it thinks 22 is the correct version. After specifying the target using node gyp env vars, it works on all except Windows. A recent issue was fixed for this last week.
I’ll remove the version target (which is dynamic, based on the node version anyway) hoping maybe the latest addresses it
y
hmmm odd! especially as the node version and prebuildify version hadn’t changed! just noted test failures in release pipeline, for testing out the uploaded prebuild. happy to pick up the relay baton on this
m
I think the issue is the latest prebuilds produce different artifact names, so the current process is expecting something else. Here’s a comparison of the before/after
(I had to upgrade from 5.0.1 to 6.0.1 because of a windows issue that cropped up)
y
ahhh there is an option to set the binding name. i bet in 6 it defaults to the name of the package.
good spot
i can get this fixed up today for you chap
m
Think I’ve found the arg (not on their docs, but it’s 
--name
or 
-n
based on the code). https://github.com/pact-foundation/pact-js-core/actions/runs/8799345769
Was just on the GTM call
y
ahh damn, timings
m
haha
y
very nice, thank you Tenacious D!
m
Just channeling my inna Yousaf mate
😅 1
hacker 1
Fucken of course it is different, it’s Windows why wouldn’t it be different!
I had to speak too soon didn’t I
y
haha ofc it is. damn widnows
hmm https://github.com/pact-foundation/pact-js-core/actions/runs/8799756204/job/24149450987#step:5:99
Copy code
prebuilds/win32-x64/node.napi.node.node
prebuilds/win32-x64/pact_ffi.dll
firing up winny vm now
m
I think it’s because windows adds the extension to the name, whereas unix doesn’t
y
Cheers homie! Hopefully its 💚 but if not, I’ll pick it up
m
I suppose there is at least one more place things can hit the fan - when the package is deployed. If you wouldn’t mind testing the released artifact, that would be ❤️
(assuming we don’t get another build failure 😛 )
y
ofc buddy, will test out and consume in pact-js
thankyou 1
m
Nice work on the release dry run step in the build though - that has definitely saved a few stingers.
I’m gunna head off now actually, will chat later mate!
thx for checking in here
y
Yeah I kept getting bitten, once bitten forever shy. right get off and it’ll be tickety boo when yer back. Sleep well man
💯 1
m
haha, I love that - tickety boo. Reminds me of Peep Show
1000 1
yesss kit 1
nighty night!
blobwave 1
Ok my bad, it was not windows fault. The extension is obviously not supposed to be in the name. I can fix tomorrow, don't waste your time it's not urgent at all
y
release is out as 14.3.4 and it pulled through automatically because it uses a caret in the package.json of pact-js, so no new release of pact-js required I believe https://github.com/pact-foundation/pact-js/actions/runs/8801373574/job/24154558497 PR :- https://github.com/pact-foundation/pact-js/pull/1212
thankyou 1
Open in Slack
PreviousNext
Powered by