Not sure if this is considered a <#CSUFRDVKN|>, bu...
# pactflowk
Kevin de Boer
03/06/2024, 12:25 PMNot sure if this is considered a #CSUFRDVKN, but I've been wondering... In case of bidirectional testing, its up to the provider to push their openapi specs to the broker, and record when a deployment has been made. Its a lot less work for the provider compared to consumer-driven. However, all our services use Swagger, which also exposes the openapi spec through an endpoint. Wouldnt be much less work still, if the pact broker could query the openapi spec directly from the environment? I imagine that the provider then wont have to do anything at all, except for maybe configure the url somewhere where to get the openapi spec from. Has there been any thoughts on this?
m
Matt (pactflow.io / pact-js / pact-go)
03/06/2024, 12:46 PM
Do you mean swagger hub?
k
Kevin de Boer
03/06/2024, 12:47 PMOh no, did I reinvent the wheel? đ
Going to check out swaggerhub now
r
rholshausen
03/06/2024, 10:19 PMI think he means the provider itself has an API that provides the OAS file.
m
Matt (pactflow.io / pact-js / pact-go)
03/06/2024, 11:06 PM
sorry I was on my mobile when I read this. That makes sense Ron/Kevin
Matt (pactflow.io / pact-js / pact-go)
03/06/2024, 11:08 PM
Wouldnt be much less work still, if the pact broker could query the openapi spec directly from the environment?Yes, I can see why you would ask that. Itâs not completely unreasonable, but that itself doesnât guarantee the API implements the spec. Thatâs why we ask for test results (even if we donât check what the results are themselves). It does raise some further workflow issues though - how do we trigger when to see if there is a new version of the spec? What if you deployed a breaking change and only after the OAS was retrieved in the target environment things were broken?
r
rholshausen
03/06/2024, 11:15 PMIf it is using things like Spring and Swagger annotations, the OAS is generated from the actual controllers, so the generated spec represents that actual API. I think BDC is more for cases where the spec is written by one team and given to another team to implement.
m
Matt (pactflow.io / pact-js / pact-go)
03/06/2024, 11:17 PM
Is it not possible to have scaffolded your code base with correct types (which would generate a âcorrectâ OAS), but have no implementation for them? Or a buggy implementation of them?
2 Views