Hey <@U9UUY3CU9> and <@UELMFD9PG> the latest FFI b...
# maintainersr
rholshausen
02/26/2024, 5:34 AMHey @Matt (pactflow.io / pact-js / pact-go) and @Yousaf Nabi (pactflow.io) the latest FFI build failed on MacOS.
blobwave 1
rholshausen
02/26/2024, 5:35 AMThere are these two lines in the build script:
Copy code
export SDKROOT=$(xcrun -sdk macosx11.1 --show-sdk-path)
export MACOSX_DEPLOYMENT_TARGET=$(xcrun -sdk macosx11.1 --show-sdk-platform-version)rholshausen
02/26/2024, 5:36 AMWe need to understand why there is a need to target the SDK like this (what is this doing to the generated dynlib) and also why it is failing
m
Matt (pactflow.io / pact-js / pact-go)
02/26/2024, 7:06 AM
was that me? I’d need to go back to check why we did that. Hopefully there is an issue.
I assume it’s not related to the install_name shenanigans. Perhaps it was an attempt to build on an older version so that it would be forward compatible?
👌 1
Matt (pactflow.io / pact-js / pact-go)
02/26/2024, 7:08 AM
Looking at the history, might have been an M1 thing: https://github.com/pact-foundation/pact-reference/blame/28eb5c2e0c4b905490a92487fdc925f14e6eb145/rust/pact_ffi/release-osx.sh
y
Yousaf Nabi (pactflow.io)
02/26/2024, 12:12 PM
im not sure why we need the sdkroot env var but you can fix it with this action
https://github.com/maxim-lobanov/setup-xcode
and set to xcode 12.4
https://github.com/pact-foundation/pact-reference/commit/2e02838e9f1196f03e6e6ed38e40d45bfa6ddc6d
macos gha github runners should have that xcode version installed but its not linking.
i think the only thing that matters there is setting the maosx deployment target to the oldest version you can support
👍 2
Yousaf Nabi (pactflow.io)
02/26/2024, 12:17 PM
tested to resolve on my fork. btw
Yousaf Nabi (pactflow.io)
02/26/2024, 12:19 PM
need to understand why there is a need to target the SDK like this (what is this doing to the generated dynlib) and also why it is failingit allows newer versions of xcode to generate binaries which can be used by older versions of macos.
👍 2
Yousaf Nabi (pactflow.io)
02/26/2024, 11:15 PM
woop woop green build 💚
j
Joshua Ellis
02/26/2024, 11:22 PMThanks!
Joshua Ellis
02/26/2024, 11:28 PMCould it be worth finding the oldest SDK version dynamically on the runner by inspecting the contents of the
/Library/Developer/CommandLineTools/SDKs/ Copy code
find /Library/Developer/CommandLineTools/SDKs/ -type d -maxdepth 1 | sort -V | tail -n+2 | head -n1 Copy code
find /Library/Developer/CommandLineTools/SDKs/ -type d -maxdepth 1 -path '*.sdk' | sort -V | head -n1