Friday I made time to go through <@U017ELYST1Q>’s ...
# maintainers
y
Friday I made time to go through @Tien Vo’s Pact-PHP working on moving to the rust core, and it is spectacular. • The migration guide • The fact consumer tests don’t need to change at all (and in fact can have things taken out of the users setup) ◦ due to not needing a pact test listener to write to file • the integration of the plugins and test demonstrations (csv and protobuf repos) and the pact plugin installer It has been tough to review because it’s so huge (nature of the beast), but has been GREAT fun to play around with the end result. Really looking forward to getting some of the snag list cleaned up today, getting it into the ``ffi` branch and getting the announcement out in our Pact OSS post on Thursday - Draft https://github.com/pact-foundation/docs.pact.io/pull/269
💪🏻 1
💪 2
m
Can’t wait to see it in action!!
I assume soon we’ll need to be releasing an alpha or something to Composer (or whatever it is PHP uses these days?)
y
you can load branches via composer, which will go in the docs, so you will require
dev-<branch>
https://github.com/pact-foundation/pact-php/issues/262
Anyone can start testing
pact-php
with
pact_ffi
code by updating their
composer.json
"pact-foundation/pact-php": "dev-ffi as 9.0.0"
Technically it is actually
dev-ffi-next
as I pushed up that to test it out on Friday but will be from that branch. I think we will want to publish @Tien Vo’s additional packages to composer so they don’t have to be loaded from a git repo (which requires tokens to avoid rate limits) https://github.com/tienvx/pact-php-protobuf https://github.com/tienvx/pact-php-csv https://github.com/tienvx/pact-php-plugin https://github.com/tienvx/pact-plugin-install If these get transferred to the pact-foundation, we will want to add Tien to the maintainers group in composer I believe, or have a pact-foundation user, so we can generate a token for any other php repos in the pact-foundation org
I assume soon we’ll need to be releasing an alpha or something to Composer (or whatever it is PHP uses these days?)
Yes, easy as creating a tag though, semantic versioning guidelines for composer are here https://getcomposer.org/doc/04-schema.md#version
🙌 1
tags are better all round tho, reading up on the docs, to get a deterministic package for the end user
👍 1
1. It’s merged! Thank you @Tien Vo 🌮 🚀 2. Raised issue to track release https://github.com/pact-foundation/pact-php/issues/324 a. cc @Mattermack / @Tien Vo 3. Updated tracking issue for latest updates on how to use/ test / provide feedback and contribute a. https://github.com/pact-foundation/pact-php/issues/262 4. Updated README to point users looking for v3 spec + to the tracking i a. https://github.com/pact-foundation/pact-php#specifications Charles - hope you don’t feel I am stepping on your toes here with the push to get Tien’s changes out. They are pretty through and haven given them a spin on and off for the last couple of months,
❤️ 2
t
Wow, a lot of thing happen when I'm away for a while ✌️
😆 2