Ulises Cervino
06/19/2023, 1:49 PMMatt (pactflow.io / pact-js / pact-go)
Matt (pactflow.io / pact-js / pact-go)
Matt (pactflow.io / pact-js / pact-go)
Slackbot
06/19/2023, 9:38 PMTimothy Jones
06/20/2023, 12:48 AMverify all branchesYou might want "verify all contracts under a certain age", plus main + deployed
Timothy Jones
06/20/2023, 12:49 AM(this one does block a provider branch since a roll out with a red job here means breakages)You don't actually have to block the build. You just have to block deploy.
Ulises Cervino
06/20/2023, 9:57 AMUlises Cervino
06/20/2023, 9:59 AMUlises Cervino
06/20/2023, 10:54 AMUlises Cervino
06/20/2023, 10:57 AMWhile the provider build may pass, the verification results are still reported (if results publishing is enabled) to the Pact Broker as "failed", as the consumer should not be able to deploy the code that generated this contract.
Ulises Cervino
06/20/2023, 10:57 AMUlises Cervino
06/20/2023, 10:57 AMUlises Cervino
06/20/2023, 12:50 PMpending=true
like so
enablePendingPacts = "true", providerBranch = "master"
for pact-jvm, and then I ran my provider tests. I know there’s a consumer branch for consumer X with contracts that can’t be successfully verified (for various reasons), however it still didn’t pick up those contracts during the run. Re-reading the docs for pending
it seems that all this does is for the main branch/deployed allow for failure in cases when the consumer pushed to their main branch/deployed contracts that can’t be verified. And the point is to not block the provider from rolling out. This is good stuff if I got it right, but it doesn’t address my issue of “publish verifications for all contracts out there”.Ulises Cervino
06/20/2023, 12:51 PMUlises Cervino
06/20/2023, 1:00 PMincludeWipPactsSince = "2023-01-01"
, and it seems like this did the trickUlises Cervino
06/20/2023, 1:01 PMPASS
in the IDE 3) I didn’t publish because IDE but I am hopeful that when this runs in CI/CD a failed
result will be publishedTimothy Jones
06/20/2023, 2:25 PMTimothy Jones
06/20/2023, 2:27 PMTimothy Jones
06/20/2023, 2:28 PMTimothy Jones
06/20/2023, 2:31 PMTimothy Jones
06/20/2023, 2:31 PMTimothy Jones
06/20/2023, 2:31 PMTimothy Jones
06/20/2023, 2:32 PMUlises Cervino
06/20/2023, 7:15 PMUlises Cervino
06/20/2023, 7:15 PMMatt (pactflow.io / pact-js / pact-go)
Ulises Cervino
06/21/2023, 6:51 AMUlises Cervino
06/21/2023, 8:34 AMthis problem stems mostly from the fact that we can’t do webhooks (networking security stuff); otherwise we’d have a way of verifying with a branch name coming from the env for instanceAn alternative is for us to have a CI job that takes the branch+consumer name from an env var, and we ask consumers to trigger this job after their publish-contracts job. It’s a bit like webhooks except we don’t go via the broker.
Matt (pactflow.io / pact-js / pact-go)
Timothy Jones
06/22/2023, 12:45 AMUlises Cervino
06/23/2023, 10:57 AM