Join Slack
Powered by
<#127 chore(dev-ex): remove docker login step from...
# pact-broker
g
GitHub
04/18/2023, 6:14 PM
#127 chore(dev-ex): remove docker login step from test run
Pull request opened by
YOU54F
PR builds from contributors fail because they don't have access to secrets to login to the docker repository. Not sure why this step is needed, as we test from the image built in the CI run, and don't push it as part of this job. Maybe its due to docker licensing restrictions? 🤷🏾♂️ It also stops dependency update builds from running the test step, which causes more headache for maintainers, example PR actions run
https://github.com/pact-foundation/pact-broker-docker/actions/runs/4675302277/jobs/8280283767#step:6:9
pact-foundation/pact-broker-docker
✅ All checks have passed 2/2 successful checks
GitHub
04/26/2023, 12:49 PM
#127 chore(dev-ex): remove docker login step from test run
Pull request merged by
YOU54F
pact-foundation/pact-broker-docker
Open in Slack
Previous
Next