small fix: <fix(sdk): skip auto-loaded plugins and...
# proj-agent
m
c
We have an issue submitted, on the similar behavior on hooks, and it raises the question what to do about the user expectation that a hook, which may be put in place to enforce a secure behavior (e.g. if it’s a check that the agent doesn’t
rm -rf /
), wouldn’t be skipped silently 🤔 I wonder if maybe the behavior could be: • via REST, start the conversation, and return the failed things in a response • via Python, fail… mmm WDYT?
Not for this PR, just trying to pick your brain
m
do you mean if something happens between the LLM and the hook? how can we be sure the hook isn't skipped?
c
I mean just like your plugins PR, if a hook fails to load
m
ah ok because we ar not surfacing that ?
I should read the issue
c
Sorry! @bland-bear-604 find the issue on the sdk about hooks that don’t load
🐾 1
b
Found it 🐾 #6376 — Agent-server is fail-open on a corrupt hooks.json. A malformed hooks file yields HTTP 200 with
hook_config: null
, silently dropping the policy hooks; the SDK loader already raises the error.
c
Ah, the SDK fails 🤔 TBH I think it’s annoying to fail every conversation, until you disable the broken hook - many are doing other things, I have hooks that review FE design 😅