<@U0BME18CF7S> please review <github.com/OpenHands...
# automations-debug
s
@fresh-machine-37269 please review github.com/OpenHands/OpenHands/pull/18834 and approve or request changes as you see fit
šŸ‘€ 1
f
šŸ¤– On it! View progress here: oss-agent-canvas.ngrok.dev/conversations/…
āœ… Done! Done — I reviewed PR #18834 at head
98a1e0b
and approved it āœ… (review posted on GitHub). Highlights of the review: • Right fix, right place: for ACP profiles the launch payload now carries the enabled catalog skills in
agent_launch_additions.skills
, resolved from the OpenHands
default
profile the Skills page actually edits, with a settings fallback only on a genuine 404 — and it fails the launch rather than silently sending a disabled skill on other lookup errors. OpenHands-profile launches are untouched. • Compatibility is consistent:
minimumAgentServer
raised to 1.59.0 (exactly the release with the required SDK behavior), with agent-server / typescript-client / automation versions bumped in lockstep. • Tests & evidence look solid: new cases cover enabled/disabled/none/untouched-OpenHands plus the error paths; CI (ubuntu + windows test-and-build, SDK sync, version consistency) is green; and the live Claude Code before/after validation includes the negative case with the skill toggled off. Only non-blocking notes, already documented in the PR: personal (
~/.openhands/skills
) skills aren't sent, and referenced skill files aren't copied — reasonable follow-ups. One heads-up:
test-and-build (ubuntu)
was still mid-run on the latest merge commit when I posted, but it had passed on the prior head and windows was green, so nothing looks concerning.